-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test uri fix #8232
Test uri fix #8232
Conversation
* Make proper unit test out of the test function * Add proper test cases
This allows addin paths to contain unicode symbols.
Refer to this link for build results (access rights to CI server needed): |
47274ce
to
650dab7
Compare
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
ddccbd9
to
2f9d797
Compare
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
* Move to common clipboard.c file * Move to header file so it can be included in test case
This macro exports internal functions in case of a unit test build This way unit tests can access these without other workarounds.
2f9d797
to
3c18284
Compare
Refer to this link for build results (access rights to CI server needed): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some smaller comments, functionality lgtm
Use a wrapper function to convert to unicode and call the function
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
* EXPORT_ALL_SYMBOLS now does as the name implies and exports all non static functions/variables from the library. * BUILD_TESTING now only sets the defines for test code and activates EXPORT_ALL_SYMBOLS to allow tests to access internal code
1ab520c
to
327b1e4
Compare
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
@hardening @mfleisz anything left here to fix? I´d like to merge this if possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Fixed TestUri unit test * Make proper unit test out of the test function * Add proper test cases * Replace FindFirstFileA with FindFirstFileW for addins This allows addin paths to contain unicode symbols. * Fixed parse_uri_to_local_file definition * Move to common clipboard.c file * Move to header file so it can be included in test case * Added WINPR_LOCAL for test builds This macro exports internal functions in case of a unit test build This way unit tests can access these without other workarounds. * Fixed typo in function name is_dos_driver * Cleaned up FindFirstFileW call Use a wrapper function to convert to unicode and call the function * Cleaned up BUILD_TESTING and EXPORT_ALL_SYMBOLS * EXPORT_ALL_SYMBOLS now does as the name implies and exports all non static functions/variables from the library. * BUILD_TESTING now only sets the defines for test code and activates EXPORT_ALL_SYMBOLS to allow tests to access internal code * Fixed windows client warnings * disable CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS
No description provided.