Fix issue #3229 Barcode Scanner USB - missing double characters #3992
Conversation
|
Can one of the admins verify this patch? |
|
hum, could you write something in your commit log about this commit ? |
johnjmullen
force-pushed
the
fix-barcode-scanner
branch
from
83435f4 to
15b3d04
Compare
johnjmullen
changed the title
With some usb barcode scanners, repeated characters do not appear in the freerdp session. It looks like this is because the KeyRelease signal is not sent for the first character. Removing this if check fixes the problem.
johnjmullen
force-pushed
the
fix-barcode-scanner
branch
from
15b3d04 to
de1868b
Compare
|
It's possible that this will break stuff. I'm not sure whether there is a reason to ignore some KeyRelease events. It looks like those lines have always been there, so they might be necessary. There was a patch in one of the comments on the bug report that sent a key release in xf_event_KeyPress, but I was concerned it might cause issues with modifier keys or holding a key down. I could try that instead if you think it would be better. |
|
Is this code meant for disabling auto repeat? I couldn't figure out why it was there, but I didn't think of that until now. |
|
@johnjmullen That may be possible, I'm not quite sure myself, need to dig into that. |
|
@freerdp-bot test |
|
Refer to this link for build results (access rights to CI server needed): |
|
@freerdp-bot test |
|
Refer to this link for build results (access rights to CI server needed): |
|
This change fixes the Intermec SG20B barcode scanner, and I have not been able to find any problems with the keyboards I have. I think the code I removed might be related to autorepeat, but everything appears to work correctly without it. Is there anything else that I should test to confirm it will not cause problems? |
|
@akallabeth Let me know if there is anything else that needs to be tested or if you need me to make any changes. |
|
@akallabeth Were you going to merge this? |
With some USB barcode scanners, repeated characters do not appear in the FreeRDP session.
It looks like this is because the KeyRelease signal is not sent for the first character.
This fixes the problem, but I'm not sure if there is a reason these KeyRelease events need to be ignored