Clear Codec and AVC420 fixes #3648
Conversation
|
@mfleisz This may fix the issues you've encountered |
|
Refer to this link for build results (access rights to CI server needed): |
There was a problem hiding this comment.
@akallabeth Just one comment - apart from that there is the "problem" with the API change.
| glyphEntry->size = glyphEntry->count; | ||
| tmp = (UINT32*) realloc(glyphEntry->pixels, glyphEntry->size * 4); | ||
| tmp = realloc(glyphEntry->pixels, glyphEntry->size * bpp); |
There was a problem hiding this comment.
I think we miss a (BYTE*) cast here
There was a problem hiding this comment.
@mfleisz You looked at the wrong end of the diff ;)
There was a problem hiding this comment.
@akallabeth You are right - should not be necessary with PODs
|
@mfleisz Refactored the changes, using an API compatible fix now. |
|
Refer to this link for build results (access rights to CI server needed): |
| glyphEntry->size = glyphEntry->count; | ||
| tmp = (UINT32*) realloc(glyphEntry->pixels, glyphEntry->size * 4); | ||
| tmp = realloc(glyphEntry->pixels, glyphEntry->size * bpp); |
There was a problem hiding this comment.
@akallabeth You are right - should not be necessary with PODs
|
@freerdp-bot test |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
| @@ -1011,6 +1011,8 @@ BOOL rfx_process_message(RFX_CONTEXT* context, const BYTE* data, UINT32 length, | |||
| BOOL ok = TRUE; | |||
| UINT16 expectedDataBlockType = WBT_FRAME_BEGIN; | |||
|
|
|||
| region16_init(&updateRegion); | |||
There was a problem hiding this comment.
Wouldn't it be easier to just move the declaration of updateRegion into the for() loop and get rid of init/uninit here and in fail:?
akallabeth
force-pushed
the
clear_codec_fixed
branch
from
9b92118 to
227efd3
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
@freerdp-bot test. |
|
@freerdp-bot test. |
|
Refer to this link for build results (access rights to CI server needed): |
|
@freerdp-bot test. |
|
Refer to this link for build results (access rights to CI server needed): |
|
@freerdp-bot test |
|
Refer to this link for build results (access rights to CI server needed): |
Fixes #3642 #3527 #3279 et al
Tested with windows 8.1 and 10 as well as android