Fix win32 linker hell and more #3410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inet_ntop is already implemented in winpr
Depending on the windows target version (_WIN32_WINNT), the used SDK and the build configuration the linker will see multiple libraries exporting the same symbols. To prevent ugly hacks (e.g. modifying cmake's default system libraries or fragile library linking order chains) we prefix these functions with "winpr_" and create corresponding defines to keep the current api names.
|
Refer to this link for build results (access rights to CI server needed): |
|
@nfedera wow. Great job. That saves a lot of troubles. I like the renaming from STATIC_CHANNELS to BUILTIN_CHANNELS very much - that makes it more clear what it in fact does. +1 |
|
nice job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
winpr: fix win32 linking issues
Depending on the windows target version (WIN32_WINNT), the used SDK and the build configuration the linker will see multiple libraries exporting the same symbols.
To prevent ugly hacks (e.g. modifying cmake's default system libraries or fragile library linking order chains) we prefix these functions with "winpr" and create corresponding defines to keep the current api names.
freerdp: remove static inet_ntop
inet_ntop is already implemented in winpr
cmake: remove some void statements and fix winpr source group
cmake: replaced STATIC_CHANNELS with BUILTIN_CHANNELS
channels/audin/client/winmm: requires winpr