-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial transport layer implementation #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awakecoding
added a commit
that referenced
this pull request
Jul 3, 2011
Initial transport layer implementation
Closed
Closed
akallabeth
pushed a commit
that referenced
this pull request
Jun 7, 2023
Uninitialized bytes in __interceptor_strlen at offset 0 inside [0x701000000040, 1) ==220==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x535c13 in freerdp_assistance_hex_string_to_bin /src/FreeRDP/libfreerdp/common/assistance.c:711:11 #1 0x533deb in LLVMFuzzerTestOneInput /src/FreeRDP/libfreerdp/common/test/TestFuzzCommonAssistanceHexStringToBin.c:5:15 #2 0x43f5f3 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:611:15 #3 0x4409a4 in fuzzer::Fuzzer::ReadAndExecuteSeedCorpora(std::__Fuzzer::vector<fuzzer::SizedFile, std::__Fuzzer::allocator<fuzzer::SizedFile> >&) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:804:3 #4 0x440e79 in fuzzer::Fuzzer::Loop(std::__Fuzzer::vector<fuzzer::SizedFile, std::__Fuzzer::allocator<fuzzer::SizedFile> >&) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:857:3 #5 0x4304df in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:912:6 #6 0x459b32 in main /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerMain.cpp:20:10 #7 0x7effc08bb082 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x24082) (BuildId: 1878e6b475720c7c51969e69ab2d276fae6d1dee) #8 0x420f1d in _start (/tmp/not-out/tmpu5o6go0a/TestFuzzCommonAssistanceHexStringToBin+0x420f1d)
akallabeth
pushed a commit
that referenced
this pull request
Jun 7, 2023
…e_file_buffer ``` READ of size 2 at 0x602000000091 thread T0 SCARINESS: 14 (2-byte-read-heap-buffer-overflow) #0 0x4c6fb9 in StrstrCheck(void*, char*, char const*, char const*) /src/llvm-project/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:580:5 #1 0x4c6df1 in strstr /src/llvm-project/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:597:5 #2 0x56c9ba in freerdp_assistance_parse_file_buffer /src/FreeRDP/libfreerdp/common/assistance.c:743:6 #3 0x56b58e in parse_file_buffer /src/FreeRDP/libfreerdp/common/test/TestFuzzCommonAssistanceParseFileBuffer.c:11:11 #4 0x56b58e in LLVMFuzzerTestOneInput /src/FreeRDP/libfreerdp/common/test/TestFuzzCommonAssistanceParseFileBuffer.c:20:2 #5 0x43f5e3 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:611:15 #6 0x440994 in fuzzer::Fuzzer::ReadAndExecuteSeedCorpora(std::__Fuzzer::vector<fuzzer::SizedFile, std::__Fuzzer::allocator<fuzzer::SizedFile> >&) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:804:3 ```
chipitsine
added a commit
to chipitsine/FreeRDP
that referenced
this pull request
Apr 6, 2024
found by coverity 705 if (transferDir == USBD_TRANSFER_DIRECTION_OUT) 706 { 18. Condition !Stream_CheckAndLogRequiredLengthEx("com.freerdp.channels.urbdrc.client" /* "com.freerdp.channels.urbdrc.client" */, 3, s, OutputBufferSize, 1, "%s(%s:%zu)" /* "%s(%s:%zu)" */, <anonymous>, "/home/runner/work/FreeRDP/FreeRDP/channels/urbdrc/client/data_transfer.c", 707UL /* (size_t)707 */), taking true branch. 707 if (!Stream_CheckAndLogRequiredLength(TAG, s, OutputBufferSize)) CID 424733: (FreeRDP#1 of 1): Resource leak (RESOURCE_LEAK) 19. leaked_storage: Variable out going out of scope leaks the storage it points to. 708 return ERROR_INVALID_DATA; 709 Stream_Copy(s, out, OutputBufferSize); 710 }
chipitsine
added a commit
to chipitsine/FreeRDP
that referenced
this pull request
Apr 6, 2024
found by coverity 655 if (Stream_Write_UTF16_String_From_UTF8(s, tmpDirCharLen - 1, tempDirectory->szTempDir, 656 ARRAYSIZE(tempDirectory->szTempDir), TRUE) < 0) CID 424748: (FreeRDP#1 of 1): Resource leak (RESOURCE_LEAK) 9. leaked_storage: Variable s going out of scope leaks the storage it points to. 657 return ERROR_INTERNAL_ERROR; 658 /* Path must be 260 UTF16 characters with '\0' termination. 659 * ensure this here */
chipitsine
added a commit
to chipitsine/FreeRDP
that referenced
this pull request
Apr 6, 2024
found by coverity 128 if (winpr_asprintf(&headers, &size, post_header_fmt, path, hostname, blen) < 0) CID 424888: (FreeRDP#1 of 1): Resource leak (RESOURCE_LEAK) 15. leaked_storage: Variable hostname going out of scope leaks the storage it points to. 129 return FALSE; 130 }
chipitsine
added a commit
to chipitsine/FreeRDP
that referenced
this pull request
Apr 7, 2024
found by coverity 128 if (winpr_asprintf(&headers, &size, post_header_fmt, path, hostname, blen) < 0) CID 424888: (FreeRDP#1 of 1): Resource leak (RESOURCE_LEAK) 15. leaked_storage: Variable hostname going out of scope leaks the storage it points to. 129 return FALSE; 130 }
akallabeth
pushed a commit
that referenced
this pull request
Apr 8, 2024
found by coverity 705 if (transferDir == USBD_TRANSFER_DIRECTION_OUT) 706 { 18. Condition !Stream_CheckAndLogRequiredLengthEx("com.freerdp.channels.urbdrc.client" /* "com.freerdp.channels.urbdrc.client" */, 3, s, OutputBufferSize, 1, "%s(%s:%zu)" /* "%s(%s:%zu)" */, <anonymous>, "/home/runner/work/FreeRDP/FreeRDP/channels/urbdrc/client/data_transfer.c", 707UL /* (size_t)707 */), taking true branch. 707 if (!Stream_CheckAndLogRequiredLength(TAG, s, OutputBufferSize)) CID 424733: (#1 of 1): Resource leak (RESOURCE_LEAK) 19. leaked_storage: Variable out going out of scope leaks the storage it points to. 708 return ERROR_INVALID_DATA; 709 Stream_Copy(s, out, OutputBufferSize); 710 }
akallabeth
pushed a commit
that referenced
this pull request
Apr 8, 2024
found by coverity 655 if (Stream_Write_UTF16_String_From_UTF8(s, tmpDirCharLen - 1, tempDirectory->szTempDir, 656 ARRAYSIZE(tempDirectory->szTempDir), TRUE) < 0) CID 424748: (#1 of 1): Resource leak (RESOURCE_LEAK) 9. leaked_storage: Variable s going out of scope leaks the storage it points to. 657 return ERROR_INTERNAL_ERROR; 658 /* Path must be 260 UTF16 characters with '\0' termination. 659 * ensure this here */
akallabeth
pushed a commit
that referenced
this pull request
Apr 8, 2024
found by coverity 128 if (winpr_asprintf(&headers, &size, post_header_fmt, path, hostname, blen) < 0) CID 424888: (#1 of 1): Resource leak (RESOURCE_LEAK) 15. leaked_storage: Variable hostname going out of scope leaks the storage it points to. 129 return FALSE; 130 }
qmfrederik
pushed a commit
to qmfrederik/FreeRDP
that referenced
this pull request
Nov 10, 2024
Fix hanging RDP connection when opposite side is down and thru forwarder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With unit testing, it's already ok to send the first X.224 Connection Request PDU, and received X.224 Connection Confirm PDU from server.