Ci v2 #7282
Ci v2 #7282
Conversation
|
Is this a draft or ready to be merged? |
|
Please wait until the check has finished (should be finished in about an hour). |
|
@donovaly |
Build and Test: - ccache - build - Unittest - install - Unittest of install - report misc: - use .clang-tidy file to configure Clang-tidy checks - use use .pylintrc to configure Pylint checks - Update changed-files Action - better regex for file extension filter - show enabled clang-tidy checks in Step Report - show enabled Pylint Checks - cpplint filter documentation - modified cpplint filters recomended by https://github.com/sider/runners/blob/HEAD/images/cpplint/sider_recommended_CPPLINT.cfg - fixed Branch filter for Clazy QT6 checks --> has only worked on pull requests - fail the CI only on Build errors, Unittest errors and misspellings
as it is now integrated into the check workflow
|
OK, let's try it out |
| run: | | ||
| set +e | ||
|
|
||
| LD_LIBRARY_PATH=/usr/lib/freecad/lib FreeCADCmd -t 0 &> ${{ env.logdir }}TestInstall.log |
There was a problem hiding this comment.
consider running the GUI tests instead, see @0penBrain's PR #6421 for how to do this, also why are we running the checks twice?
There was a problem hiding this comment.
I tried to run the GUI checks, but with the Ubuntu 22.04 runner Xvfb gives me problems 😞 . On Ubuntu 20.04, Xvfb works fine. It's on my to-do list, but I wanted to get this out quickly after my last botched PR. (And as of next week, I'm on vacation)
Maybe the first testing can be omitted, I left it in because cmake install + testing on the install was giving me problems and I can easily turn it on and off that way. And the 5min extra runtime is negligible after we don't have to pay for GitHub actions anyway.
There was a problem hiding this comment.
I'm not sure if we want to run on Ubuntu 22.04 it has a broken version of pivy and I doubt they'll be updating that. About the double testing, IMO it would clutter output so it's not convenient to us to begin with and besides just because a service is free doesn't mean you have to abuse it, let's be a little considerate with GitHub and not waste CPU time for nothing.
* Github: Build and Test Build and Test: - ccache - build - Unittest - install - Unittest of install - report misc: - use .clang-tidy file to configure Clang-tidy checks - use use .pylintrc to configure Pylint checks - Update changed-files Action - better regex for file extension filter - show enabled clang-tidy checks in Step Report - show enabled Pylint Checks - cpplint filter documentation - modified cpplint filters recomended by https://github.com/sider/runners/blob/HEAD/images/cpplint/sider_recommended_CPPLINT.cfg - fixed Branch filter for Clazy QT6 checks --> has only worked on pull requests - fail the CI only on Build errors, Unittest errors and misspellings * Github: remove Codespell action as it is now integrated into the check workflow
* Github: Build and Test Build and Test: - ccache - build - Unittest - install - Unittest of install - report misc: - use .clang-tidy file to configure Clang-tidy checks - use use .pylintrc to configure Pylint checks - Update changed-files Action - better regex for file extension filter - show enabled clang-tidy checks in Step Report - show enabled Pylint Checks - cpplint filter documentation - modified cpplint filters recomended by https://github.com/sider/runners/blob/HEAD/images/cpplint/sider_recommended_CPPLINT.cfg - fixed Branch filter for Clazy QT6 checks --> has only worked on pull requests - fail the CI only on Build errors, Unittest errors and misspellings * Github: remove Codespell action as it is now integrated into the check workflow
|
Hello Florian, (do you have by the way also a forum account and what is your name there?) I see a bug I cannot resolve:
Could you have a look please? For reverence this is the log of our Gitlab CI where the skipping was accepted: thanks and regards |
|
Strange, I thought that was supposed to work out-of-the-box: Here are the docs: I wonder if it's case-sensitive? |
|
Thanks. This was my mistake. one must use non-uppercase letters. |
Build and Test:
misc: