Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update outdated testing library dependencies #2968

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

carbonrobot
Copy link
Contributor

@carbonrobot carbonrobot commented Nov 13, 2024

Updates outdated testing library dependencies that rely on much older versions of peer deps than we currently target,

This change also removes the low-value test in the victory-native package. The newest testing library is incompatible with the way we wrap our components for React Native and the value of the test is not worth the workaround we have to maintain for it.

Copy link

changeset-bot bot commented Nov 13, 2024

⚠️ No Changeset found

Latest commit: c65f0e0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview Nov 13, 2024 10:32pm

@carbonrobot carbonrobot merged commit a63cb04 into main Nov 14, 2024
7 checks passed
@carbonrobot carbonrobot deleted the chore/testing-library-deps branch November 14, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants