[TASK] Cleanups in FalViewHelper #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix phpDoc annotations, yoda-style comparisons and other small improvements.
| } catch (ResourceDoesNotExistException $exception) { | ||
| // No handling, just omit the invalid reference uid | ||
| continue; | ||
| $images = array(); |
There was a problem hiding this comment.
Moving declaration of $images in here may cause the variable to be undefined (or at least not an array) which would cause the final loop to break with a fatal PHP error. It should be okay to move the declaration outside of the condition so it always gets initialised but only filled if referenceUids is not empty. Sorry, missed the declaration above. Code should execute just fine, despite the slightly confusing reuse of $images variable which was there before you got here :)
NamelessCoder
added a commit
that referenced
this pull request
Dec 14, 2015
[TASK] Cleanups in FalViewHelper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix phpDoc annotations, yoda-style comparisons and other small
improvements.