[BUGFIX] Incorrect variable container index #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -651,8 +651,8 @@ public function renderContent($menu) { | |||
| $tagContent = $this->autoRender($menu); | |||
| $this->tag->setContent($tagContent); | |||
| $deferredContent = $this->tag->render(); | |||
| $this->viewHelperVariableContainer->addOrUpdate('FluidTYPO3\Vhs\ViewHelpers\Page\Menu\AbstractMenuViewHelper', 'deferredString', $deferredContent); | |||
| $this->viewHelperVariableContainer->addOrUpdate('FluidTYPO3\Vhs\ViewHelpers\Page\Menu\AbstractMenuViewHelper', 'deferredArray', $menu); | |||
| $this->viewHelperVariableContainer->addOrUpdate('\FluidTYPO3\Vhs\ViewHelpers\Page\Menu\AbstractMenuViewHelper', 'deferredString', $deferredContent); | |||
There was a problem hiding this comment.
The correct way is actually without leading backslash - if there are other occurrences we should fix those instead ;)
There was a problem hiding this comment.
why would we not use a fully qualified name?
There was a problem hiding this comment.
It's just an array key and thus some sort of CGL I guess.
|
Roger that. Force pushed. |
|
Reply for Danilo's lost question:
We always would, except when the class name is a string value like it is here. This includes |
NamelessCoder
added a commit
that referenced
this pull request
Jul 10, 2014
[BUGFIX] Incorrect variable container index
|
Ah ok. Kind of weird of ObjectManager though :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.