-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG][TYPO3-8.6.1] flux:field.text with CKEdit #1388
Comments
This behavior is still showing up on typo3 8.7 with the latest development-branch of flux. |
I ran into the same problem today. I was using TYPO3 8.7.0 and latest flux release. By looking at the TCA configuration for the default content elements of TYPO3 i noticed that there is additional configuration for content elements which use the RTE. 'columnsOverrides' => [
'bodytext' => [
'config' => [
'enableRichtext' => true,
'richtextConfiguration' => 'default'
]
]
] I was able to fix the problem in flux by adding the above configuration to the if (true === $this->getEnableRichText()) {
$configuration['enableRichtext'] = true;
$configuration['richtextConfiguration'] = 'default';
} Just add it before |
Hi, thanks a lot for your investigation and the fix for the problem. This saved my weekend ;)
This also explains why RTE-fields added by flexforms ignore the typoscript-settings for the configuration. Let's hope that namelesscoder will find a way for this to reach the next release. edit: too fast concerning the config issue. this setting gets ignored as well. but this is another issue. |
Had the same problem with both TYPO3 8.6 + rte_htmlarea and TYPO8.7 + CKEditor so i don't think it is related to the RTE but to the TYPO3 core (nevertheless flux should take it into account) beware that CKEditor allows to have different RTE configuration depending on the field (see below) and that hard coding "default" does not seem to be the best solution (but it fixes this problem indeed) RTE.tt_content.types.textmedia.bodytext.preset = full |
The config is another issue then the empty lines and is completely messy with any kind of flexform-rte-fields and is definitely a core issue. the empty lines on the other hand have only shown up in flux and the problem gets fixed by setting |
Is the |
There was a post on the german forums, reporting this issue, where someone wanted to create the issue. It seems like that never happened. forum-thread: I am pretty busy atm and cant take look into the issues atm. I hope i have the time tomorrow. |
Hi, I did a little research and maybe I have found something. A solution might be to prevent these empty lines. I have no idea where to do this, if this is an easy fix, or if it's even possible. Edit: |
I added |
Hello, I have this in TYPOscript but does not work for me, can any one know about it. RTE.tt_content.types.textmedia.bodytext.preset = full |
I can confirm the solution, @TheNaderio suggested. I patched |
Who know why
Have influence for all RTE instead flexform, why? |
Enables switching the CKEditor configuration based on the current field. This option falls back to `default` and can be overriden through TypoScript: ``` plugin.tx_flux.settings.flexform.richtextConfiguration = MySite ``` Closes: FluidTYPO3#1388
@olegkarun You particular problem is that the flexforms for fluidcontent are entirely created by flux and dont tage you PageTS into account. For the rest: I've pushed a fix in #1426 - could you please test it and report your results there? |
@cedricziel your patch seems to address the problem of @olegkarun. Your fix takes the RTE configuration 'default' into account, but I didn't try it with a custom one. |
@codeKerl issue with empty line just solved with hard code in flux. More info here https://stackoverflow.com/questions/44844329/fluxfield-text-ckeditor-add-new-empty-p-p-in-backend-every-save-action |
Enables switching the CKEditor configuration based on the current field. This option falls back to `default` and can be overriden through TypoScript: ``` plugin.tx_flux.settings.flexform.richtextConfiguration = MySite ``` Resolves: FluidTYPO3#1388
TYPO3 8.0 dropped "Normal" TCA gets automatically migrated, but since this here is dynamically created this migrator does not work. That core change was in commit https://git.typo3.org/Packages/TYPO3.CMS.git/commit/00677ce4cc5731d6adb621d011caca7fcbd34274 |
Enables switching the CKEditor configuration based on the current field. This option falls back to `default` and can be overriden through TypoScript: ``` plugin.tx_flux.settings.flexform.richtextConfiguration = MySite ``` Resolves: FluidTYPO3#1388
Enables switching the CKEditor configuration based on the current field. This option falls back to the system-wide flux RTE PageTSconfig: RTE.tx_flux.preset If that one is not set, TYPO3's default RTE PageTSconfig is used: RTE.default.preset Resolves: FluidTYPO3#1388
Enables switching the CKEditor configuration based on the current field. This option falls back to the system-wide flux RTE PageTSconfig: RTE.tx_flux.preset If that one is not set, TYPO3's default RTE PageTSconfig is used: RTE.default.preset Resolves: FluidTYPO3#1388
Enables switching the CKEditor configuration based on the current field. This option falls back to the system-wide flux RTE PageTSconfig: RTE.tx_flux.preset If that one is not set, TYPO3's default RTE PageTSconfig is used: RTE.default.preset Resolves: FluidTYPO3#1388
Enables switching the CKEditor configuration based on the current field. This option falls back to the system-wide flux RTE PageTSconfig: RTE.tx_flux.preset If that one is not set, TYPO3's default RTE PageTSconfig is used: RTE.default.preset Resolves: FluidTYPO3#1388
Enables switching the CKEditor configuration based on the current field. This option falls back to the system-wide flux RTE PageTSconfig: RTE.tx_flux.preset If that one is not set, TYPO3's default RTE PageTSconfig is used: RTE.default.preset Resolves: FluidTYPO3#1388
Enables switching the CKEditor configuration based on the current field. This option falls back to the system-wide flux RTE PageTSconfig: RTE.tx_flux.preset If that one is not set, TYPO3's default RTE PageTSconfig is used: RTE.default.preset Resolves: FluidTYPO3#1388
@cweiske It was dropped in 8.6 (I assume it's just a typo). Doesn't matter if it had been 8.0 though since our minimum is now 8.7 and we can remove our |
Enables switching the CKEditor configuration based on the current field. If empty, the page-wide RTE preset from PageTSconfig is used: RTE.default.preset Resolves: FluidTYPO3#1388 (cherry picked from commit 00100ee)
Do you plan to release a 8.7 tag of flux? |
@NamelessCoder I would also appreciate a new release to get this working with Typo3 ^8.7 :) |
One suggestion before this is added to a new Flux version. Override the "FluidTYPO3\Flux\Form\Field\Text" class and extend it with your class in your extension and just add this method inside:
This will do the trick. |
Hi, it seems like multiple issues are being discussed here. I was actually lead here by FluidTYPO3/fluidcontent#422 which describes my problem accurately. Is my understanding correct, that in its current development version CK editor presets now also work with Flux templates? If so, when can we expect this fix/feature to be released? I'm currently updating a site that uses both, Flux and a customized RTE quite extensively. |
@RKlingler: That's correct! But a colleague of mine had this problem again, while copying old RTE-content into the new CK-Editor. |
There is still no 8.7 tag. How you handle this problem in composer projects? |
|
@luzat Thomas, the xclass solution works very well. Thanks! |
Hi there, But my system will be updated by composer, so if i change anything in extension-directories class-file it will be overwritten on next composer update. Can somebody tell me how i can solve this problem by adding the code in external file by using composer? |
Please use the development branch. Or follow the advice above and use XCLASS if for some reason you cannot use the development branch. Locking issue since it was closed almost one year ago. |
Hi,
first of all please excuse my poor english due to it not being my native language. I hope you can get what i am pointing at nonetheless.
With an Update to Version 8.6.1 and activating CKEdit as RTE the editor shows a pretty unwanted behavior.
On every save-action there are empty lines added around every line-end. This results in multiple
&nbsc;
with an exponential growth. This problem only occurs within flux-forms. When adding a rte-field with FlexForms everything works as intended.Example with Flux (adding tons of empty lines):
Example with Flexform (working as intended):
I am not sure what transformations are applied to the flux-field-content but since it only occurs with the usage of flux i guess that the bug is not related to the core and i hope you have the time to have a look at it soon.
Please tell me what additional information you need or what further steps i could take to better assist you.
Kind regards
Patric
edit: using flux 8.1.0 from ter
The text was updated successfully, but these errors were encountered: