!!! BUGFIX: Contexts are respected in a multi-site environment. #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniellienert
force-pushed
the
bugfix/fix-suggestion-context
branch
2 times, most recently
from
804031d to
8edf106
Compare
Multiple contexts are treaded as disjunction. That means, nodes are suggested if they either are in the live workspace or from the requested site, which makes the site restriction worthless. This fix merges the site, workspace and hidden state into one context and uses that for filtering. Fixes: Flowpack#54
daniellienert
force-pushed
the
bugfix/fix-suggestion-context
branch
from
8edf106 to
0e0951c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple contexts are treaded as disjunction. That means, nodes are suggested if they either are in the live workspace
or from the requested site, which makes the site restriction worthless.
This fix merges the site, workspace and hidden state into one context and uses that for filtering.
Fixes: #54