Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[add] Discord Notifier: silent notification property #4017

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

Winter
Copy link
Contributor

@Winter Winter commented Jul 14, 2024

Motivation for changes:

Wanted to have a notification go out when something is grabbed and another go out when it's available, but didn't want to be notified that it was grabbed, only that it was available; without creating two separate channels.

Detailed changes:

  • Added new property called silent onto discord notifier plugin.
  • Check if silent is true, set property flags onto web_hook object with the suppress notification bitfield set.

Config usage if relevant (new plugin or updated schema):

notify:
  task:
    message: <message>
    via:
      - discord:
          web_hook_url: <web_hook_url>
          silent: true

https://discord.com/developers/docs/resources/webhook#execute-webhook-jsonform-params

@BrutuZ
Copy link
Contributor

BrutuZ commented Jul 14, 2024

Huh, I was just considering changing my notifications to conditionally include a ping to my user/role but this might be more elegant, and easier too since I won't have to make my already very messy message template even worse with more Jinja formulas

@gazpachoking gazpachoking merged commit cc92fad into Flexget:develop Jul 17, 2024
8 checks passed
@gazpachoking
Copy link
Member

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants