Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] set Manipulate to ignore rejected entries #3126

Merged
merged 5 commits into from
Sep 7, 2021

Conversation

trananhtuan
Copy link
Contributor

Motivation for changes:

Currently manipulate processes rejected entries, which is problematic. I don't understand the reason for this in the first place.

For example, I want to use manipulate to replace title with imdb_name. Some entries don't have valid imdb metadata, which causes manipulate to crash when trying to set title to None. This could be solved by using required_field: imdb_name and setting plugin_priority for manipulate to lower than required_field but it doesn't work because manupulate will process rejected entries also. This causes the task to crash.

Detailed changes:

set manipulate to ignore rejected entries

@trananhtuan trananhtuan marked this pull request as ready for review August 15, 2021 06:50
@paranoidi
Copy link
Member

I think this makes more sense.

@paranoidi paranoidi merged commit 1e19d17 into Flexget:develop Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants