fix duplicate pushes with pushbullet #253
Conversation
|
Hmm. With this patch, won't only the first accepted item cause a notification? |
by not specifying any device idens, the push will be sent to all devices of the user. or the user can specify only the devices they want to receive pushes on.
|
ok i fixed the problem properly this time. pushbullet needs to update their api doc to mention that by not specifying a device iden, the msg will be delivered to all devices owned by the user. please check the new commit. should be flawless now :-) |
| @@ -47,7 +47,7 @@ def prepare_config(self, config): | |||
| config.setdefault("body", "{% if series_name is defined %}{{tvdb_series_name|d(series_name)}} " | |||
| "{{series_id}} {{tvdb_ep_name|d('')}}{% elif imdb_name is defined %}{{imdb_name}} " | |||
| "{{imdb_year}}{% else %}{{title}}{% endif %}") | |||
|
|
|||
| config.setdefault("device", "Nothing") | |||
There was a problem hiding this comment.
Rather than using a specific string here, I'd just use None
There was a problem hiding this comment.
wouldnt doing that cause the for loop to not run due to "devices" being nothing?
There was a problem hiding this comment.
devices would end up being [None] i.e. a list with one item in it.
There was a problem hiding this comment.
ah i see... ill test it out and push a new commit. thanks... im new to python :)
|
ok @gazpachoking i've made the changes you suggested. let me know if u spot any more. thanks! |
dj-nitehawk
changed the title
fix duplicate pushes with pushbullet
|
Thanks! |
issue described here: http://discuss.flexget.com/t/pushbullet-plugin-sending-2-pushes-per-match/81