-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subtask input plugin #2478
Add subtask input plugin #2478
Conversation
I totally get the need for this, but this feels very hacky. I think ideally we want that ability to chain tasks to each other and that should be the direction, and not neccesarily introduce new hybrid solutions like this. |
@liiight How do you mean chain tasks? |
I sorta like this method. It doesn't really allow anything different than clearing then saving to an entry_list and using it somewhere else, but this way feels like it might be a bit easier. I've considered chaining tasks with something similar to run_task, but that passes entries along, but that doesn't help us in cases where we want to use the entries inside discover, or configure_series |
I've tried putting something down only to get something almost similar to what you did, so NM :) |
Change subtask name to use > instead of .
@liiight @paranoidi @cvium Any thoughts on the TODO checklist questions? I like this method, but want to get a little feedback on those points before merging it in. |
@liiight @paranoidi Is |
|
That's the way I'm leaning as well. I think it makes it more clear it's just an input. Especially if already familiar with from_deluge etc. |
Wiki update: Flexget/wiki@e336ec4 |
Does the flexget.com search database need to be updated when adding new plugins? I searched for "from_task" in the search bar on flexget.com "https://flexget.com/_search?q=from_task" but it comes up empty. I guessed the url and it took me to the page, so I know it DOES exist. I think there may have been a handful of other plugins that don't come up in a search, too. But I cannot remember which ones... |
Seems like maybe the search index update was getting bypassed when syncing from the github repo (or something.) I've added a weekly cronjob to re-index, hopefully that keeps things working better. |
Motivation for changes:
Be able to manipulate and filter entries before passing in to plugins like configure_series, or discover.
Detailed changes:
Config usage if relevant (new plugin or updated schema):
To Do:
parenttask>subtask
is that good?good enough for me.
Decided against this for now at least.
Skipping this for now. Can always be added later.
Let's not pass any options through right now. If we discover something that should be we can re-think.