Update NPO_watchlists tests #2446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Dynasties series is no longer available * Description for Zondag met Lubach has changed
|
I don't know why CircleCI failed, it seems as if it has not applied the first of the two commits for running the tests on the updated cassettes? Locally all the tests do pass :-/ (hence the updated cassettes) |
|
Re-ran the tests and cassettes, now it seems to be ok |
|
Could this (trivial) update to the tests please be merged; my server runs with every NPO-website these tests to check for any regressions, so having working tests greatly helps ;-) |
|
Yep, looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
The NPO website had some changes; updated the tests to reflect this