Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[change] Add pagination headers to history api even if no items are present #2422

Merged
merged 2 commits into from
Jul 29, 2019

Conversation

kristenmills
Copy link
Member

Motivation for changes:

Making Total Count explicitly 0 makes it easier for me to handle infinite scroll for this plugin from the web-ui.

Detailed changes:

  • Add pagination headers in empty response from GET history api endpoint

@gazpachoking
Copy link
Member

Looks good to me.

@gazpachoking gazpachoking merged commit 6ceb052 into develop Jul 29, 2019
@kristenmills kristenmills deleted the history_total_count branch July 29, 2019 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants