Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transmission overhaul #2330

Merged
merged 11 commits into from
Feb 11, 2019
Merged

transmission overhaul #2330

merged 11 commits into from
Feb 11, 2019

Conversation

gazpachoking
Copy link
Member

@gazpachoking gazpachoking commented Feb 7, 2019

Motivation for changes:

Deprecate clean_transmission. Provide parity for upcoming deluge plugin enhancements (#2325, #2329) in transmission.

Detailed changes:

from_transmissoin:

  • Set onlycomplete default to false
  • Fix onlycomplete option to make sense
  • rename onlycomplete to only_complete
  • Provide more fields from transmission for use in filtering

transmission:

  • Add action option to allow pause/resume/remove/purge ability
  • Add underscores between words in option names. (max_up_speed, max_down_speed, max_connections, add_paused, bandwidth_priority, honour_limits)

clean_transmission:

  • Deprecate it in favor of task with from_transmission, and transmission plugin with remove/purge action set.
  • Probably needs fixed a bit based on my changes to the seed/idle limit completed function

Addressed issues:

from_transmission: fix onlycomplete option
from_transmission: make onlycomplete default to false
transmission: Clean up code
@gazpachoking gazpachoking changed the base branch from develop to next February 8, 2019 02:15
@gazpachoking gazpachoking merged commit 85ad91c into next Feb 11, 2019
@gazpachoking gazpachoking deleted the transmission_control branch March 26, 2019 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants