Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize from_deluge fields #2325

Merged
merged 3 commits into from
Feb 11, 2019
Merged

Standardize from_deluge fields #2325

merged 3 commits into from
Feb 11, 2019

Conversation

gazpachoking
Copy link
Member

@gazpachoking gazpachoking commented Feb 5, 2019

Motivation for changes:

from_deluge plugin provides only a subset of fields from deluge, some come standard, some have to be specifically requested in config. Also, some come with a different name than deluge uses, and some come with some value manipulation from the raw deluge value.

Detailed changes:

  • Provide every field, as-is from deluge as entry fields with the format deluge_<deluge_field_name>
  • Still does some processing/renaming for a few other fields outside of deluge_ namespace which we have a 'standard' for:
    • torrent_info_hash
    • torrent_peers
    • torrent_seeds
    • content_size
    • content_files
  • Removes the 'keys' option from from_deluge config

Addressed issues:

Config updates needed

  • Time based fields from deluge were previously provided in hours, they are now provided in seconds
  • Several fields will now have a new name, and fields provided may be different depending on deluge version and plugins enabled. Best bet is to run a test and see provided fields which can be used: flexget --test execute --task my_from_deluge_task --dump

TODO

  • Test this
  • Maybe add deluge_id field back in. Deluge output plugin was using this to know if a given entry originated from deluge, and therefore did not need to be re-downloaded.

@gazpachoking gazpachoking changed the title [WIP] Standardize from_deluge fields Standardize from_deluge fields Feb 7, 2019
@gazpachoking gazpachoking mentioned this pull request Feb 7, 2019
3 tasks
@gazpachoking gazpachoking changed the base branch from develop to next February 8, 2019 02:16
@gazpachoking gazpachoking merged commit 14ddebe into next Feb 11, 2019
@gazpachoking gazpachoking deleted the from_deluge_fields branch March 26, 2019 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant