Python3.7 support #2193
Closed
Python3.7 support #2193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related #2189. Added 3.7 image to docker hub. |
|
Hmm, all tests seem to be passing on this PR, should we merge it as-is, and open another ticket to track further needs? |
|
@gazpachoking Sadly, this one basically just tracks all the other needed items for py3.7 and tests last ran when the #2162 was merged. The regex building logic is a bit of a mess and might require more than meets the eye to get working correctly. |
|
Gotcha. Maybe I'll try to tackle the regex stuff then. I'm thinking we'll just need to fix our usage of re.sub, and require users to escape their own regex substitutions if they are specifying a replacement in the config. |
2 tasks
|
This was replaced by #2225, which has now been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
Add Python 3.7 support, some of the stuff not covered in #2162
Detailed changes:
To Do: