Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set hasEmitted for initialData #370

Merged
merged 3 commits into from
May 6, 2021
Merged

Set hasEmitted for initialData #370

merged 3 commits into from
May 6, 2021

Conversation

jhuleatt
Copy link
Collaborator

@jhuleatt jhuleatt commented May 4, 2021

Description

Fixes #342

  • Have useObservable set hasEmitted to true when initialData is passed in
    • Added a test to verify this behavior
  • Update ObservableStatus docs to make the values more clear

@google-cla google-cla bot added the cla: yes label May 4, 2021
jamesdaniels
jamesdaniels approved these changes May 6, 2021
View reviewed changes
Copy link
Collaborator

@jamesdaniels jamesdaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhuleatt jhuleatt merged commit 01150bd into main May 6, 2021
@jhuleatt jhuleatt deleted the jhuleatt-auth-hasemitted branch May 6, 2021 17:23
@FirebaseExtended FirebaseExtended locked and limited conversation to collaborators Jun 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jamesdaniels jamesdaniels jamesdaniels approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Observable hasEmitted with useUser Hook never gets true
2 participants
@jhuleatt @jamesdaniels