Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #52 #53

Merged
merged 2 commits into from
Jul 11, 2013
Merged

Fix for issue #52 #53

merged 2 commits into from
Jul 11, 2013

Conversation

donomans
Copy link
Contributor

@donomans donomans commented Jul 7, 2013

This should cause it to check the initial path so the authRequired attribute is counted even on the first path hit.

donomans added 2 commits July 7, 2013 15:48
@donomans
Fix for issue FirebaseExtended#52
9984eed 
This should cause it to check the initial path so the authRequired attribute is counted even on the first path hit.
@donomans
Fix for issue FirebaseExtended#52 part 2
d825540
@anantn anantn closed this Jul 9, 2013
@katowulf katowulf reopened this Jul 9, 2013
@anantn
Copy link
Contributor

anantn commented Jul 11, 2013

Not sure why the PR closed itself, I think I should change my Github password :/

Good catch, thanks for the contribution @fronn!

anantn added a commit that referenced this pull request Jul 11, 2013
@anantn
Merge pull request #53 from fronn/patch-1
82e5d17 
Fix for issue #52
@anantn anantn merged commit 82e5d17 into FirebaseExtended:gh-pages Jul 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@donomans @anantn @katowulf