Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize for Ostracon #263

Merged
merged 8 commits into from
Jun 1, 2021
Merged

Initialize for Ostracon #263

merged 8 commits into from
Jun 1, 2021

Conversation

tnasu
Copy link
Member

@tnasu tnasu commented May 31, 2021

Description

We made Ostracon from forking Tendermint.

DONE(see "Commits"):

  • docs: Rewrite README.md for Ostracon
  • docs: Initialize RELEASE_NOTES.md
  • docs: Update LICENSE
  • docs: Re-Define policies
  • docs: Initialize docs for Ostracon
  • docs: Update documents to Ostracon
  • fix: Remove the remaining "make tools"

TODO(will fix another PR):

  • fix: Rename the binary of tendermint into ostracon

@@ -1,11 +1,9 @@
# Unreleased Changes

## v0.34.11
## v0.0.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we describe here what we have implemented in Ostracon so far? In the case of lbm and lbm-sdk, the CHANGELOG_PENDING file is not going to be kept separately, so I recorded them all in the CHANGELOG.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove CHANGELOG_PENDING.md. Thanks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE: f480c88

@egonspace
Copy link
Contributor

I think we can remove docs/imgs directory.

@tnasu
Copy link
Member Author

tnasu commented May 31, 2021

I think we can remove docs/imgs directory.

Thanks for your checking! docs/imgs/contributing.png is using in CONTRIBUTING.md

[Contributing flow](./docs/imgs/contributing.png)

@tnasu tnasu self-assigned this May 31, 2021
@tnasu tnasu requested review from zemyblue, torao, AmosDoan and Kynea0b May 31, 2021 06:19

# Tendermint will be looking for the genesis file in /tendermint/config/genesis.json
# Ostracon will be looking for the genesis file in /tendermint/config/genesis.json
# (unless you change `genesis_file` in config.toml). You can put your config.toml and
# private validator file into /tendermint/config.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/tendermint/config ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't change the enviroment of Docker since it needs to change the source codes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I change the documents?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, thank you.

service: 'reddit',
url: 'https://reddit.com/r/cosmosnetwork'
service: 'note',
url: 'https://note.com/line_blockchain'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WoW

@tnasu tnasu removed the request for review from AmosDoan May 31, 2021 08:58
@tnasu tnasu merged commit 7403bdd into Finschia:main Jun 1, 2021
tnasu added a commit that referenced this pull request Jun 29, 2021
* docs: Rewrite README.md for Ostracon

* docs: Initialize RELEASE_NOTES.md

* docs: Update LICENSE

* docs: Re-Define policies

* docs: Initialize docs for Ostracon

* docs: Update documents to Ostracon

* fix: Remove the remaining "make tools"

* (squash) Remove CHANGELOG_PENDING.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants