Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate collection names #164

Merged
merged 29 commits into from
Jul 11, 2022
Merged

Validate collection names #164

merged 29 commits into from
Jul 11, 2022

Conversation

seeforschauer
Copy link
Contributor

@seeforschauer seeforschauer commented Jul 6, 2022 •
edited by AlekSi
Loading

Closes FerretDB/FerretDB#806.

Case FerretDB MongoDB Status
system. fails: system. contains a dot fails: system. is a reserved prefix skipped as both fail
_ferretdb_ fails: _ferretdb_ is a reserved prefix pass added
max length 120 255 added
dots fail pass added
dashes fail pass added

Corresponding FerretDB PR #844.

@seeforschauer seeforschauer self-assigned this Jul 6, 2022
@seeforschauer seeforschauer marked this pull request as ready for review July 8, 2022 14:42
@seeforschauer seeforschauer requested a review from a team as a code owner July 8, 2022 14:42
@seeforschauer seeforschauer added the code/feature Some dance tool feature is not implemented yet label Jul 8, 2022
rumyantseva
rumyantseva reviewed Jul 8, 2022
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, looks good to me (added a tiny typo fix and a question).

tests/diff/collection_name_test.go Outdated Show resolved Hide resolved
tests/diff/collection_name_test.go Outdated Show resolved Hide resolved
AlekSi
AlekSi reviewed Jul 8, 2022
View reviewed changes
tests/diff/collection_name_test.go Outdated Show resolved Hide resolved
tests/diff/collection_name_test.go Outdated Show resolved Hide resolved
seeforschauer and others added 6 commits July 11, 2022 08:43
rumyantseva
rumyantseva previously approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AlekSi
AlekSi reviewed Jul 11, 2022
View reviewed changes
tests/diff/null_strings_test.go Outdated Show resolved Hide resolved
tests/diff/collection_name_test.go Outdated Show resolved Hide resolved
@seeforschauer @AlekSi
Update tests/diff/null_strings_test.go
785083e 
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
@seeforschauer seeforschauer requested a review from AlekSi July 11, 2022 11:28
@AlekSi AlekSi merged commit 65f4490 into FerretDB:main Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@noisersup noisersup Awaiting requested review from noisersup

@rumyantseva rumyantseva Awaiting requested review from rumyantseva

Assignees

@seeforschauer seeforschauer

Labels
code/feature Some dance tool feature is not implemented yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate collection names
3 participants
@seeforschauer @AlekSi @rumyantseva