Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TODOs #852

Merged
merged 6 commits into from
Jul 7, 2022
Merged

Add TODOs #852

merged 6 commits into from
Jul 7, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 6, 2022

No description provided.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Jul 6, 2022
@AlekSi AlekSi added this to the v0.5.0 milestone Jul 6, 2022
@AlekSi AlekSi self-assigned this Jul 6, 2022
@AlekSi AlekSi requested a review from rumyantseva as a code owner July 6, 2022 16:02
@AlekSi AlekSi enabled auto-merge (squash) July 6, 2022 16:02
@AlekSi AlekSi requested review from a team, seeforschauer and noisersup and removed request for a team July 6, 2022 16:02
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #852 (d84f8fc) into main (979bb25) will decrease coverage by 0.08%.
The diff coverage is 37.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #852      +/-   ##
==========================================
- Coverage   59.12%   59.03%   -0.09%     
==========================================
  Files         218      218              
  Lines        9841     9845       +4     
==========================================
- Hits         5818     5812       -6     
- Misses       3315     3322       +7     
- Partials      708      711       +3     
Impacted Files Coverage Δ
internal/handlers/pg/pg.go 100.00% <ø> (ø)
internal/handlers/tigris/msg_delete.go 0.00% <0.00%> (ø)
internal/handlers/pg/msg_delete.go 45.26% <75.00%> (+1.17%) ⬆️
internal/clientconn/conninfo/conn_info.go 66.66% <0.00%> (-16.67%) ⬇️
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
internal/handlers/pg/pgdb/pool.go 57.39% <0.00%> (-0.59%) ⬇️
Flag Coverage Δ
integration 61.50% <75.00%> (-0.03%) ⬇️
mongodb 18.79% <0.00%> (-0.05%) ⬇️
pg 61.43% <75.00%> (-0.03%) ⬇️
unit 24.73% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi disabled auto-merge July 7, 2022 09:39
@AlekSi AlekSi merged commit ced68a5 into FerretDB:main Jul 7, 2022
@AlekSi AlekSi deleted the todos branch July 7, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants