-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate collection names #844
Conversation
Codecov Report
@@ Coverage Diff @@
## main #844 +/- ##
==========================================
- Coverage 59.09% 59.07% -0.02%
==========================================
Files 218 218
Lines 9845 9855 +10
==========================================
+ Hits 5818 5822 +4
- Misses 3318 3322 +4
- Partials 709 711 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
In the PR body there is a case
max length in FerretDB: 255, in MongoDB: 63.
. Should it bemax length in FerretDB: 119
? or what 119 is about? :) -
Are dance cases in the scope of this task? Or is there a separate issue for it?
-
It's great that there is a new piece of doc for README. It's not 100% full/accurate (I added a couple of comments about it).
-
Special thanks for updating
CreateCollection
godoc.
Please pay attention to the caption - it's a difference between FerretDB and MongoDB.
Not sure about 119, it's a magic number for now. And yes, this magic number is not in the constant somewhere, I follow the task guideline that we can change it later.
It is in the scope of the task and it is not in the scope of the PR since the repository is FerretDB.
Added, thank you for noting this.
You are welcome ^ - ^. I'm glad I have a command to check what docs look like (thanks to @AlekSi). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR refs #806.
Difference to be documented in dance tests:
_ferretdb_
, MongoDB -system.
.