Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support $comment query operator #563

Merged
merged 5 commits into from
May 11, 2022
Merged

Support $comment query operator #563

merged 5 commits into from
May 11, 2022

Conversation

ribaraka
Copy link
Contributor

@ribaraka ribaraka commented May 5, 2022 •
edited by AlekSi
Loading

Closes #168.

@ribaraka ribaraka requested a review from AlekSi as a code owner May 5, 2022 12:20
@ribaraka ribaraka changed the title Support $comment query operator Support $comment query operator May 5, 2022
@codecov
Copy link

codecov bot commented May 5, 2022 •
edited
Loading

Codecov Report

Merging #563 (b690ee8) into main (b7cc283) will decrease coverage by 0.22%.
The diff coverage is 39.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #563      +/-   ##
==========================================
- Coverage   61.63%   61.40%   -0.23%     
==========================================
  Files         121      121              
  Lines        6782     6820      +38     
==========================================
+ Hits         4180     4188       +8     
- Misses       2085     2110      +25     
- Partials      517      522       +5
Impacted Files Coverage Δ
internal/handlers/pg/msg_findandmodify.go 0.00% <0.00%> (ø)
internal/handlers/pg/msg_count.go 47.14% <25.00%> (-4.42%) ⬇️
internal/handlers/pg/msg_delete.go 45.74% <29.41%> (-3.12%) ⬇️
internal/handlers/pg/msg_update.go 48.88% <47.05%> (-1.90%) ⬇️
internal/handlers/pg/msg_find.go 61.81% <47.82%> (-4.54%) ⬇️
internal/handlers/common/filter.go 85.61% <100.00%> (+0.03%) ⬆️
internal/handlers/pg/fetch.go 63.41% <100.00%> (+8.86%) ⬆️
Flag Coverage Δ
FerretDB 55.13% <39.21%> (-0.20%) ⬇️
MongoDB 6.50% <0.00%> (-0.04%) ⬇️
integration 55.16% <39.21%> (-0.20%) ⬇️
unit 26.18% <0.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@seeforschauer seeforschauer added this to the v0.2.1 milestone May 5, 2022
seeforschauer
seeforschauer suggested changes May 5, 2022
View reviewed changes
internal/handlers/pg/msg_find.go Show resolved Hide resolved
internal/handlers/pg/fetch.go Outdated Show resolved Hide resolved
internal/handlers/pg/fetch.go Outdated Show resolved Hide resolved
internal/handlers/pg/msg_find.go Show resolved Hide resolved
@ribaraka ribaraka requested review from seeforschauer and AlekSi May 5, 2022 15:11
seeforschauer
seeforschauer suggested changes May 9, 2022
View reviewed changes
Copy link
Contributor

@seeforschauer seeforschauer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If protoFetch is ok, then let's ad remove old fetch and rename protoFetch to fetch.
We cannot have 2 functions: it's misleading and complicates things.

AlekSi
AlekSi reviewed May 9, 2022
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

protoFetch looks good, let's replace existing fetch with it

internal/handlers/pg/fetch.go Outdated Show resolved Hide resolved
internal/handlers/pg/fetch.go Outdated Show resolved Hide resolved
@ribaraka ribaraka force-pushed the comment-168 branch 2 times, most recently from 2671274 to 48ea3e4 Compare May 10, 2022 10:06
@ribaraka ribaraka requested review from seeforschauer and AlekSi May 10, 2022 10:12
@AlekSi AlekSi linked an issue May 10, 2022 that may be closed by this pull request
Support $comment query operator #168
Closed
@AlekSi AlekSi enabled auto-merge (squash) May 10, 2022 10:59
AlekSi
AlekSi requested changes May 10, 2022
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve merge conflicts

integration/basic_test.go Show resolved Hide resolved
seeforschauer
seeforschauer suggested changes May 10, 2022
View reviewed changes
Copy link
Contributor

@seeforschauer seeforschauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ribaraka would you please resolve conflicts

auto-merge was automatically disabled May 11, 2022 10:16

Head branch was pushed to by a user without write access

@ribaraka ribaraka requested a review from AlekSi May 11, 2022 10:37
@ribaraka ribaraka requested a review from seeforschauer May 11, 2022 10:37
@AlekSi AlekSi enabled auto-merge (squash) May 11, 2022 14:37
@AlekSi AlekSi merged commit c003ad8 into FerretDB:main May 11, 2022
@AlekSi AlekSi added the code/feature Some user-visible feature is not implemented yet label May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seeforschauer seeforschauer seeforschauer approved these changes

@AlekSi AlekSi AlekSi approved these changes

@w84thesun w84thesun Awaiting requested review from w84thesun

Assignees

@ribaraka ribaraka

Labels
code/feature Some user-visible feature is not implemented yet
Projects
None yet
Milestone
v0.2.1
Development

Successfully merging this pull request may close these issues.

Support $comment query operator
3 participants
@ribaraka @AlekSi @seeforschauer