Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checkdocs Github cache on CI #4509

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Fix checkdocs Github cache on CI #4509

merged 4 commits into from
Jul 31, 2024

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Jul 31, 2024 •
edited
Loading

Description

Closes #4171.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@noisersup noisersup added the code/chore Code maintenance improvements label Jul 31, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.34%. Comparing base (9011dbe) to head (3468d85).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4509      +/-   ##
==========================================
- Coverage   74.48%   73.34%   -1.15%     
==========================================
  Files         329      329              
  Lines       23067    23067              
==========================================
- Hits        17182    16918     -264     
- Misses       4613     4915     +302     
+ Partials     1272     1234      -38

see 17 files with indirect coverage changes

Flag Coverage Δ
filter-true 65.99% <ø> (-1.20%) ⬇️
hana-1 ?
integration 65.99% <ø> (-1.20%) ⬇️
mongodb-1 5.34% <ø> (ø)
postgresql-1 42.07% <ø> (ø)
postgresql-2 42.06% <ø> (+0.02%) ⬆️
postgresql-3 41.82% <ø> (+<0.01%) ⬆️
postgresql-4 43.46% <ø> (+0.03%) ⬆️
postgresql-5 44.73% <ø> (-0.03%) ⬇️
sqlite-1 41.03% <ø> (ø)
sqlite-2 41.14% <ø> (-0.03%) ⬇️
sqlite-3 40.84% <ø> (+0.03%) ⬆️
sqlite-4 42.33% <ø> (-0.04%) ⬇️
sqlite-5 43.79% <ø> (-0.01%) ⬇️
unit 33.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup marked this pull request as ready for review July 31, 2024 11:17
@noisersup noisersup requested a review from AlekSi as a code owner July 31, 2024 11:17
@noisersup noisersup added this to the Next milestone Jul 31, 2024
@noisersup noisersup requested review from a team, rumyantseva and chilagrow July 31, 2024 11:17
@noisersup noisersup enabled auto-merge (squash) July 31, 2024 11:18
@noisersup noisersup changed the title Fix checkdocs Github Cache on CI Fix checkdocs Github cache on CI Jul 31, 2024
@AlekSi AlekSi disabled auto-merge July 31, 2024 11:40
@AlekSi AlekSi merged commit a05cafe into FerretDB:main Jul 31, 2024
33 of 36 checks passed
@noisersup noisersup deleted the fix-after-checkdocs branch July 31, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi Awaiting requested review from AlekSi AlekSi is a code owner

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva was automatically assigned from FerretDB/core

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow was automatically assigned from FerretDB/core

Assignees

@noisersup noisersup

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.24.0
Development

Successfully merging this pull request may close these issues.

checkdocs should check if linked issues are still open
2 participants
@noisersup @AlekSi