Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use wireclient package #4502

Merged
merged 8 commits into from
Aug 1, 2024
Merged

Use wireclient package #4502

merged 8 commits into from
Aug 1, 2024

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Jul 30, 2024 •
edited
Loading

Description

Also add an option to use low level driver in integration test.

Closes FerretDB/engineering#182.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/chore Code maintenance improvements label Jul 30, 2024
@chilagrow chilagrow added this to the Next milestone Jul 30, 2024
@chilagrow chilagrow self-assigned this Jul 30, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 2.17391% with 90 lines in your changes missing coverage. Please review.

Project coverage is 73.35%. Comparing base (9a45a2b) to head (9627914).

Files Patch % Lines
integration/setup/conn.go 0.00% 66 Missing ⚠️
integration/setup/setup.go 7.69% 23 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4502      +/-   ##
==========================================
- Coverage   74.44%   73.35%   -1.10%     
==========================================
  Files         329      329              
  Lines       23068    22971      -97     
==========================================
- Hits        17174    16850     -324     
- Misses       4619     4903     +284     
+ Partials     1275     1218      -57
Files Coverage Δ
integration/setup/client.go 70.27% <ø> (+18.27%) ⬆️
integration/setup/setup.go 68.96% <7.69%> (-13.39%) ⬇️
integration/setup/conn.go 0.00% <0.00%> (ø)

... and 14 files with indirect coverage changes

Flag Coverage Δ
filter-true 66.26% <2.17%> (-0.89%) ⬇️
hana-1 ?
integration 66.26% <2.17%> (-0.89%) ⬇️
mongodb-1 5.37% <2.17%> (+0.03%) ⬆️
postgresql-1 42.26% <2.17%> (+0.18%) ⬆️
postgresql-2 42.25% <2.17%> (+0.18%) ⬆️
postgresql-3 42.00% <2.17%> (+0.17%) ⬆️
postgresql-4 43.64% <2.17%> (+0.26%) ⬆️
postgresql-5 44.93% <2.17%> (+0.16%) ⬆️
sqlite-1 41.21% <2.17%> (+0.17%) ⬆️
sqlite-2 41.33% <2.17%> (+0.15%) ⬆️
sqlite-3 40.99% <2.17%> (+0.15%) ⬆️
sqlite-4 42.48% <2.17%> (+0.19%) ⬆️
sqlite-5 43.96% <2.17%> (+0.17%) ⬆️
unit 33.37% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow marked this pull request as ready for review July 30, 2024 06:59
@chilagrow chilagrow requested review from AlekSi and a team as code owners July 30, 2024 06:59
@chilagrow chilagrow requested review from rumyantseva, a team and noisersup July 30, 2024 06:59
@chilagrow chilagrow enabled auto-merge (squash) July 30, 2024 06:59
@AlekSi AlekSi marked this pull request as draft July 30, 2024 10:09
auto-merge was automatically disabled July 30, 2024 10:09

Pull request was converted to draft

AlekSi
AlekSi reviewed Jul 30, 2024
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put it on hold until the we merge a similar PR in v2 repo

@AlekSi AlekSi removed request for a team, rumyantseva and noisersup July 30, 2024 10:10
@chilagrow chilagrow changed the title Use wireclient Use wireclient package Aug 1, 2024
@chilagrow chilagrow marked this pull request as ready for review August 1, 2024 08:17
@chilagrow chilagrow requested review from a team, rumyantseva and noisersup August 1, 2024 08:17
@chilagrow chilagrow requested a review from AlekSi August 1, 2024 08:17
@chilagrow chilagrow enabled auto-merge (squash) August 1, 2024 08:18
@chilagrow chilagrow merged commit efe2130 into FerretDB:main Aug 1, 2024
30 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva was automatically assigned from FerretDB/core

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@chilagrow @AlekSi @noisersup