Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup logging #4489

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Cleanup logging #4489

merged 3 commits into from
Jul 24, 2024

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Jul 24, 2024 •
edited
Loading

Description

Closes #4013.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/chore Code maintenance improvements label Jul 24, 2024
@chilagrow chilagrow added this to the Next milestone Jul 24, 2024
@chilagrow chilagrow self-assigned this Jul 24, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.82%. Comparing base (858324e) to head (c58860a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4489      +/-   ##
==========================================
+ Coverage   73.80%   73.82%   +0.02%     
==========================================
  Files         329      329              
  Lines       22904    22892      -12     
==========================================
- Hits        16904    16900       -4     
+ Misses       4762     4756       -6     
+ Partials     1238     1236       -2
Files Coverage Δ
internal/clientconn/cursor/registry.go 91.91% <ø> (ø)
internal/util/logging/handler.go 77.50% <ø> (-1.08%) ⬇️
internal/util/logging/logging.go 66.66% <ø> (-4.77%) ⬇️
internal/util/testutil/logging.go 100.00% <100.00%> (ø)
internal/util/testutil/postgresql.go 94.73% <100.00%> (ø)
ferretdb/ferretdb.go 82.92% <0.00%> (ø)

... and 3 files with indirect coverage changes

Flag Coverage Δ
filter-true 67.02% <100.00%> (+0.05%) ⬆️
hana-1 ?
integration 67.02% <100.00%> (+0.05%) ⬆️
mongodb-1 5.42% <0.00%> (+<0.01%) ⬆️
postgresql-1 42.73% <100.00%> (?)
postgresql-2 42.70% <100.00%> (+<0.01%) ⬆️
postgresql-3 42.47% <100.00%> (+<0.01%) ⬆️
postgresql-4 44.12% <100.00%> (+0.02%) ⬆️
postgresql-5 45.44% <100.00%> (+0.01%) ⬆️
sqlite-1 41.67% <0.00%> (+0.02%) ⬆️
sqlite-2 41.79% <0.00%> (-0.01%) ⬇️
sqlite-3 41.50% <0.00%> (+0.03%) ⬆️
sqlite-4 42.93% <0.00%> (-0.04%) ⬇️
sqlite-5 44.45% <0.00%> (+<0.01%) ⬆️
unit 33.53% <66.66%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow marked this pull request as ready for review July 24, 2024 08:11
@chilagrow chilagrow requested review from AlekSi and a team as code owners July 24, 2024 08:11
@chilagrow chilagrow requested review from rumyantseva, a team and noisersup July 24, 2024 08:11
@chilagrow chilagrow enabled auto-merge (squash) July 24, 2024 08:12
@AlekSi AlekSi disabled auto-merge July 24, 2024 09:23
@AlekSi AlekSi merged commit 400b82d into FerretDB:main Jul 24, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.24.0
Development

Successfully merging this pull request may close these issues.

Use slog for logging
2 participants
@chilagrow @AlekSi