Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop old dependency #4486

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Drop old dependency #4486

merged 3 commits into from
Jul 24, 2024

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 23, 2024 •
edited
Loading

Description

We almost did it in #4481, but not quite.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added this to the Next milestone Jul 23, 2024
@AlekSi AlekSi self-assigned this Jul 23, 2024
@AlekSi AlekSi added the code/chore Code maintenance improvements label Jul 23, 2024
@AlekSi AlekSi marked this pull request as ready for review July 23, 2024 17:12
@AlekSi AlekSi requested a review from a team as a code owner July 23, 2024 17:12
@AlekSi AlekSi requested review from rumyantseva and chilagrow July 23, 2024 17:12
@AlekSi AlekSi enabled auto-merge (squash) July 23, 2024 17:12
@AlekSi AlekSi requested review from a team and noisersup July 23, 2024 17:12
@codecov Codecov
Copy link

codecov bot commented Jul 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.14%. Comparing base (8825076) to head (8da6ebb).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4486      +/-   ##
==========================================
- Coverage   73.78%   71.14%   -2.64%     
==========================================
  Files         330      330              
  Lines       22905    22904       -1     
==========================================
- Hits        16900    16296     -604     
- Misses       4768     5375     +607     
+ Partials     1237     1233       -4
Files Coverage Δ
internal/util/testutil/logging.go 100.00% <100.00%> (ø)

... and 35 files with indirect coverage changes

Flag Coverage Δ
filter-true 64.05% <0.00%> (-2.97%) ⬇️
hana-1 ?
integration 64.05% <0.00%> (-2.97%) ⬇️
mongodb-1 5.42% <0.00%> (+<0.01%) ⬆️
postgresql-1 42.73% <0.00%> (+<0.01%) ⬆️
postgresql-2 ?
postgresql-3 42.47% <0.00%> (+<0.01%) ⬆️
postgresql-4 44.10% <0.00%> (+0.03%) ⬆️
postgresql-5 45.43% <0.00%> (+0.01%) ⬆️
sqlite-1 41.65% <0.00%> (+0.01%) ⬆️
sqlite-2 ?
sqlite-3 41.42% <0.00%> (+<0.01%) ⬆️
sqlite-4 42.97% <0.00%> (-0.05%) ⬇️
sqlite-5 44.43% <0.00%> (+0.01%) ⬆️
unit 33.49% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

chilagrow
chilagrow approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AlekSi AlekSi merged commit ba6510a into FerretDB:main Jul 24, 2024
30 of 31 checks passed
@AlekSi AlekSi deleted the slogt branch July 24, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @chilagrow @noisersup