Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and document /debug/archive handler #4485

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Refactor and document /debug/archive handler #4485

merged 4 commits into from
Jul 24, 2024

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 23, 2024 •
edited
Loading

Description

DRY code, improve test.

Closes #3584.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Jul 23, 2024
@AlekSi AlekSi changed the title Refactor /debug/archive handler Refactor and document /debug/archive handler Jul 23, 2024
@mergify mergify bot assigned AlekSi Jul 23, 2024
@AlekSi AlekSi added this to the Next milestone Jul 23, 2024
@AlekSi AlekSi added documentation Something user-visible is badly or not documented code/chore Code maintenance improvements and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Jul 23, 2024
@AlekSi AlekSi marked this pull request as ready for review July 23, 2024 17:02
@AlekSi AlekSi requested review from ptrfarkas and a team as code owners July 23, 2024 17:02
@AlekSi AlekSi requested review from rumyantseva and chilagrow July 23, 2024 17:02
@AlekSi AlekSi enabled auto-merge (squash) July 23, 2024 17:02
@AlekSi AlekSi requested review from a team, noisersup and Fashander July 23, 2024 17:02
@codecov Codecov
Copy link

codecov bot commented Jul 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.81818% with 8 lines in your changes missing coverage. Please review.

Project coverage is 73.73%. Comparing base (6d62d9a) to head (5d58d4f).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4485      +/-   ##
==========================================
+ Coverage   73.66%   73.73%   +0.06%     
==========================================
  Files         330      330              
  Lines       22867    22871       +4     
==========================================
+ Hits        16846    16863      +17     
+ Misses       4777     4767      -10     
+ Partials     1244     1241       -3
Files Coverage Δ
internal/util/debug/debug.go 82.82% <81.81%> (+8.60%) ⬆️

... and 3 files with indirect coverage changes

Flag Coverage Δ
filter-true 66.79% <4.54%> (-0.02%) ⬇️
hana-1 ?
integration 66.79% <4.54%> (-0.02%) ⬇️
mongodb-1 5.43% <4.54%> (-0.01%) ⬇️
postgresql-1 42.61% <4.54%> (+<0.01%) ⬆️
postgresql-2 42.53% <4.54%> (-0.01%) ⬇️
postgresql-3 42.30% <4.54%> (-0.03%) ⬇️
postgresql-4 43.93% <4.54%> (-0.08%) ⬇️
postgresql-5 45.31% <4.54%> (-0.04%) ⬇️
sqlite-1 41.51% <4.54%> (-0.02%) ⬇️
sqlite-2 41.59% <4.54%> (-0.01%) ⬇️
sqlite-3 41.30% <4.54%> (+0.01%) ⬆️
sqlite-4 42.86% <4.54%> (+19.60%) ⬆️
sqlite-5 44.31% <4.54%> (-0.04%) ⬇️
unit 33.57% <81.81%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

noisersup
noisersup approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chilagrow
chilagrow approved these changes Jul 24, 2024
View reviewed changes
internal/util/debug/debug.go Show resolved Hide resolved
@AlekSi AlekSi disabled auto-merge July 24, 2024 06:48
@AlekSi AlekSi merged commit b203258 into FerretDB:main Jul 24, 2024
50 checks passed
@AlekSi AlekSi deleted the refactor branch July 24, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@Fashander Fashander Fashander approved these changes

@chilagrow chilagrow chilagrow approved these changes

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements documentation Something user-visible is badly or not documented
Projects
Current Engineering
Archived in project
Milestone
v1.23.0
Development

Successfully merging this pull request may close these issues.

Implement /debug/archive
4 participants
@AlekSi @chilagrow @Fashander @noisersup