Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send OpenTelemetry traces and spans to OTLP endpoint #4484

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Send OpenTelemetry traces and spans to OTLP endpoint #4484

merged 3 commits into from
Jul 23, 2024

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 23, 2024 •
edited
Loading

Description

Closes #3244.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify mergify bot assigned AlekSi Jul 23, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 23, 2024

@AlekSi this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Jul 23, 2024
AlekSi added 2 commits July 23, 2024 17:36
@AlekSi
Add docs
9856308
@AlekSi
Merge branch 'main' into observability-docs
922c56f 
# Conflicts:
#	integration/setup/startup.go
@mergify mergify bot removed the conflict PRs that have merge conflicts label Jul 23, 2024
@AlekSi AlekSi added documentation Something user-visible is badly or not documented code/feature Some user-visible feature is not implemented yet trust PRs that can access Actions secrets labels Jul 23, 2024
@AlekSi AlekSi added this to the Next milestone Jul 23, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.57143% with 6 lines in your changes missing coverage. Please review.

Project coverage is 73.75%. Comparing base (3f1e013) to head (922c56f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4484      +/-   ##
==========================================
+ Coverage   73.68%   73.75%   +0.06%     
==========================================
  Files         330      330              
  Lines       22811    22820       +9     
==========================================
+ Hits        16809    16831      +22     
+ Misses       4764     4756       -8     
+ Partials     1238     1233       -5
Files Coverage Δ
integration/setup/startup.go 66.66% <100.00%> (ø)
internal/util/observability/observability.go 75.00% <75.00%> (+6.42%) ⬆️

... and 6 files with indirect coverage changes

Flag Coverage Δ
filter-true 66.98% <78.57%> (+0.07%) ⬆️
hana-1 ?
integration 66.98% <78.57%> (+0.07%) ⬆️
mongodb-1 5.43% <78.57%> (+0.03%) ⬆️
postgresql-1 42.69% <78.57%> (+0.02%) ⬆️
postgresql-2 42.60% <78.57%> (+<0.01%) ⬆️
postgresql-3 42.42% <78.57%> (+0.05%) ⬆️
postgresql-4 44.02% <78.57%> (+0.02%) ⬆️
postgresql-5 45.44% <78.57%> (+0.04%) ⬆️
sqlite-1 41.60% <78.57%> (+0.02%) ⬆️
sqlite-2 41.66% <78.57%> (-0.01%) ⬇️
sqlite-3 41.45% <78.57%> (+0.05%) ⬆️
sqlite-4 42.96% <78.57%> (+0.10%) ⬆️
sqlite-5 44.45% <78.57%> (+0.04%) ⬆️
unit 33.45% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review July 23, 2024 13:44
@AlekSi AlekSi requested review from ptrfarkas and a team as code owners July 23, 2024 13:44
@AlekSi AlekSi requested review from rumyantseva and chilagrow July 23, 2024 13:44
@AlekSi AlekSi enabled auto-merge (squash) July 23, 2024 13:44
@AlekSi AlekSi requested review from a team, noisersup and Fashander July 23, 2024 13:45
rumyantseva
rumyantseva approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AlekSi AlekSi disabled auto-merge July 23, 2024 16:32
@AlekSi AlekSi merged commit 6d62d9a into FerretDB:main Jul 23, 2024
45 of 69 checks passed
@AlekSi AlekSi deleted the observability-docs branch July 23, 2024 16:32
@AlekSi AlekSi changed the title Enable and document OTLP configuration Send OpenTelemetry traces and spans to OTLP endpoint Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@Fashander Fashander Fashander approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow is a code owner automatically assigned from FerretDB/leads

Assignees

@AlekSi AlekSi

Labels
code/feature Some user-visible feature is not implemented yet documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets
Projects
Current Engineering
Archived in project
Milestone
v1.23.0
Development

Successfully merging this pull request may close these issues.

Extend observability package
4 participants
@AlekSi @rumyantseva @Fashander @noisersup