Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use slog in integration tests #4481

Merged
merged 9 commits into from
Jul 22, 2024
Merged

Use slog in integration tests #4481

merged 9 commits into from
Jul 22, 2024

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Jul 22, 2024 •
edited by AlekSi
Loading

Description

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/chore Code maintenance improvements label Jul 22, 2024
@chilagrow chilagrow added this to the Next milestone Jul 22, 2024
@chilagrow chilagrow self-assigned this Jul 22, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 73.21429% with 15 lines in your changes missing coverage. Please review.

Project coverage is 73.69%. Comparing base (a4b7e70) to head (cd30ce6).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4481      +/-   ##
==========================================
- Coverage   73.76%   73.69%   -0.08%     
==========================================
  Files         330      330              
  Lines       22841    22859      +18     
==========================================
- Hits        16848    16845       -3     
- Misses       4755     4773      +18     
- Partials     1238     1241       +3
Files Coverage Δ
integration/setup/listener.go 74.05% <100.00%> (ø)
internal/util/logging/logging.go 52.94% <100.00%> (ø)
internal/util/logging/zap.go 84.00% <100.00%> (ø)
integration/setup/setup.go 82.35% <83.33%> (+0.30%) ⬆️
integration/setup/setup_compat.go 85.89% <83.33%> (+0.37%) ⬆️
internal/util/testutil/logging.go 83.33% <75.00%> (-16.67%) ⬇️
integration/setup/startup.go 66.66% <61.53%> (+2.77%) ⬆️

... and 8 files with indirect coverage changes

Flag Coverage Δ
filter-true 66.74% <71.42%> (-0.34%) ⬇️
hana-1 ?
integration 66.74% <71.42%> (-0.34%) ⬇️
mongodb-1 5.35% <48.21%> (-0.19%) ⬇️
postgresql-1 42.56% <67.85%> (-0.24%) ⬇️
postgresql-2 42.46% <67.85%> (-0.29%) ⬇️
postgresql-3 42.30% <67.85%> (-0.21%) ⬇️
postgresql-4 43.96% <67.85%> (-0.15%) ⬇️
postgresql-5 45.31% <67.85%> (-0.24%) ⬇️
sqlite-1 41.48% <64.28%> (-0.26%) ⬇️
sqlite-2 41.51% <64.28%> (-0.28%) ⬇️
sqlite-3 41.24% <64.28%> (-0.25%) ⬇️
sqlite-4 42.82% <64.28%> (-0.23%) ⬇️
sqlite-5 44.28% <64.28%> (-0.22%) ⬇️
unit 33.63% <28.57%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow marked this pull request as ready for review July 22, 2024 07:47
@chilagrow chilagrow requested a review from a team as a code owner July 22, 2024 07:47
@chilagrow chilagrow requested review from AlekSi, rumyantseva, a team and noisersup July 22, 2024 07:47
@chilagrow chilagrow enabled auto-merge (squash) July 22, 2024 07:48
rumyantseva
rumyantseva approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chilagrow chilagrow merged commit 6312dab into FerretDB:main Jul 22, 2024
31 of 32 checks passed
@AlekSi AlekSi mentioned this pull request Jul 23, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi Awaiting requested review from AlekSi AlekSi is a code owner automatically assigned from FerretDB/leads

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@chilagrow @rumyantseva @noisersup