Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement slog.LogValuer interface for types package #4479

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Implement slog.LogValuer interface for types package #4479

merged 4 commits into from
Jul 22, 2024

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Jul 19, 2024 •
edited by AlekSi
Loading

Description

It will be used by logger in

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/chore Code maintenance improvements label Jul 19, 2024
@chilagrow chilagrow added this to the Next milestone Jul 19, 2024
@chilagrow chilagrow self-assigned this Jul 19, 2024
@chilagrow chilagrow changed the title Implement slog.LogValuer interface for types package. Implement slog.LogValuer interface for types package Jul 19, 2024
@chilagrow chilagrow mentioned this pull request Jul 19, 2024
Merged
9 tasks
@codecov Codecov
Copy link

codecov bot commented Jul 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.15385% with 22 lines in your changes missing coverage. Please review.

Project coverage is 71.23%. Comparing base (ddd5169) to head (6698e6a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4479      +/-   ##
==========================================
- Coverage   73.78%   71.23%   -2.55%     
==========================================
  Files         327      330       +3     
  Lines       22776    22841      +65     
==========================================
- Hits        16805    16271     -534     
- Misses       4735     5340     +605     
+ Partials     1236     1230       -6
Files Coverage Δ
internal/types/array.go 85.84% <100.00%> (-1.66%) ⬇️
internal/types/document.go 87.55% <100.00%> (+0.12%) ⬆️
internal/types/binary.go 0.00% <0.00%> (ø)
internal/types/null.go 0.00% <0.00%> (ø)
internal/types/object_id.go 77.77% <0.00%> (-9.73%) ⬇️
internal/types/regex.go 80.00% <0.00%> (-3.73%) ⬇️
internal/types/timestamp.go 83.33% <0.00%> (-16.67%) ⬇️
internal/types/logging.go 76.47% <76.47%> (ø)

... and 32 files with indirect coverage changes

Flag Coverage Δ
filter-true 64.21% <0.00%> (-3.06%) ⬇️
hana-1 ?
integration 64.21% <0.00%> (-3.06%) ⬇️
mongodb-1 5.54% <0.00%> (-0.02%) ⬇️
postgresql-1 42.80% <0.00%> (-0.14%) ⬇️
postgresql-2 ?
postgresql-3 42.54% <0.00%> (-0.12%) ⬇️
postgresql-4 44.17% <0.00%> (-0.06%) ⬇️
postgresql-5 45.54% <0.00%> (-0.12%) ⬇️
sqlite-1 41.73% <0.00%> (-0.13%) ⬇️
sqlite-2 ?
sqlite-3 41.53% <0.00%> (-0.14%) ⬇️
sqlite-4 42.98% <0.00%> (-0.19%) ⬇️
sqlite-5 44.56% <0.00%> (-0.07%) ⬇️
unit 33.65% <66.15%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow marked this pull request as ready for review July 19, 2024 07:21
@chilagrow chilagrow requested a review from a team as a code owner July 19, 2024 07:21
@chilagrow chilagrow requested review from AlekSi, rumyantseva, a team and noisersup July 19, 2024 07:21
@chilagrow chilagrow mentioned this pull request Jul 19, 2024
Merged
9 tasks
@chilagrow chilagrow enabled auto-merge (squash) July 19, 2024 08:55
@chilagrow chilagrow merged commit a4b7e70 into FerretDB:main Jul 22, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi Awaiting requested review from AlekSi AlekSi is a code owner automatically assigned from FerretDB/leads

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@chilagrow @rumyantseva @noisersup