Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenTelemetry traces and spans #4477

Merged
merged 7 commits into from
Jul 19, 2024
Merged

Add OpenTelemetry traces and spans #4477

merged 7 commits into from
Jul 19, 2024

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 18, 2024

Description

Tested manually.

CleanShot 2024-07-18 at 23 27 51@2x

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify mergify bot assigned AlekSi Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 82.07547% with 19 lines in your changes missing coverage. Please review.

Project coverage is 73.81%. Comparing base (150f1d3) to head (23a2037).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4477      +/-   ##
==========================================
+ Coverage   73.72%   73.81%   +0.09%     
==========================================
  Files         327      327              
  Lines       22694    22774      +80     
==========================================
+ Hits        16731    16811      +80     
+ Misses       4733     4731       -2     
- Partials     1230     1232       +2     
Files Coverage Δ
integration/setup/listener.go 74.05% <100.00%> (+0.33%) ⬆️
integration/setup/setup_compat.go 92.10% <100.00%> (+5.85%) ⬆️
internal/clientconn/conn.go 50.94% <100.00%> (+1.76%) ⬆️
integration/setup/setup.go 82.05% <85.71%> (+2.71%) ⬆️
internal/backends/database.go 94.36% <90.00%> (-1.72%) ⬇️
internal/handler/handler.go 55.11% <50.00%> (+1.95%) ⬆️
internal/backends/backend.go 85.18% <66.66%> (-5.30%) ⬇️
internal/backends/collection.go 85.18% <75.00%> (-6.00%) ⬇️

... and 4 files with indirect coverage changes

Flag Coverage Δ
filter-true 67.30% <80.18%> (+0.10%) ⬆️
hana-1 ?
integration 67.30% <80.18%> (+0.10%) ⬆️
mongodb-1 5.55% <5.66%> (-0.03%) ⬇️
postgresql-1 42.92% <74.52%> (+0.10%) ⬆️
postgresql-2 42.84% <74.52%> (+0.09%) ⬆️
postgresql-3 42.62% <70.75%> (+0.06%) ⬆️
postgresql-4 44.30% <72.64%> (+0.14%) ⬆️
postgresql-5 45.66% <72.64%> (+0.11%) ⬆️
sqlite-1 41.85% <74.52%> (+0.11%) ⬆️
sqlite-2 41.88% <74.52%> (+0.11%) ⬆️
sqlite-3 41.65% <72.64%> (+0.14%) ⬆️
sqlite-4 43.22% <72.64%> (+0.09%) ⬆️
sqlite-5 44.63% <70.75%> (+0.10%) ⬆️
unit 33.54% <41.30%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added this to the Next milestone Jul 18, 2024
@AlekSi AlekSi added the code/feature Some user-visible feature is not implemented yet label Jul 18, 2024
@AlekSi AlekSi requested review from a team, rumyantseva, chilagrow and noisersup July 18, 2024 19:31
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, the change made on integration test setup seems more natural now.

@AlekSi AlekSi marked this pull request as ready for review July 19, 2024 08:31
@AlekSi AlekSi requested a review from a team as a code owner July 19, 2024 08:31
@AlekSi AlekSi enabled auto-merge (squash) July 19, 2024 09:07
@AlekSi AlekSi merged commit 1a28bb6 into FerretDB:main Jul 19, 2024
32 of 34 checks passed
@AlekSi AlekSi deleted the spans branch July 19, 2024 10:33
@AlekSi AlekSi changed the title Add OTel spans Add OpenTelemetry traces and spans Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/feature Some user-visible feature is not implemented yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants