Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FuncCall #4476

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Remove FuncCall #4476

merged 2 commits into from
Jul 18, 2024

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 18, 2024 •
edited
Loading

Description

This API is not good enough.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi
Remove FuncCall
f71fc5b 
This API is not good enough.
@mergify mergify bot assigned AlekSi Jul 18, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 18, 2024

@AlekSi this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Jul 18, 2024
@AlekSi
Merge branch 'main' into remove-funccall
fc34ee7 
# Conflicts:
#	internal/backends/sqlite/metadata/pool/pool.go
@mergify mergify bot removed the conflict PRs that have merge conflicts label Jul 18, 2024
@AlekSi AlekSi added this to the Next milestone Jul 18, 2024
@AlekSi AlekSi added the code/chore Code maintenance improvements label Jul 18, 2024
@AlekSi AlekSi marked this pull request as ready for review July 18, 2024 11:15
@AlekSi AlekSi requested a review from a team as a code owner July 18, 2024 11:15
@AlekSi AlekSi requested review from rumyantseva and chilagrow July 18, 2024 11:15
@AlekSi AlekSi enabled auto-merge (squash) July 18, 2024 11:15
@codecov Codecov
Copy link

codecov bot commented Jul 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.71%. Comparing base (8fdcfd9) to head (fc34ee7).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4476      +/-   ##
==========================================
- Coverage   74.58%   73.71%   -0.87%     
==========================================
  Files         328      327       -1     
  Lines       22826    22690     -136     
==========================================
- Hits        17025    16727     -298     
- Misses       4581     4733     +152     
- Partials     1220     1230      +10
Files Coverage Δ
integration/setup/client.go 70.27% <ø> (-0.79%) ⬇️
integration/setup/listener.go 73.71% <ø> (-5.27%) ⬇️
integration/setup/setup.go 79.33% <ø> (+0.59%) ⬆️
integration/setup/setup_compat.go 86.25% <ø> (-6.61%) ⬇️
internal/backends/backend.go 90.47% <ø> (-0.64%) ⬇️
internal/backends/collection.go 91.17% <ø> (-1.14%) ⬇️
internal/backends/database.go 96.07% <ø> (-0.36%) ⬇️
internal/backends/decorators/oplog/collection.go 76.63% <ø> (-0.64%) ⬇️
internal/backends/hana/query_iterator.go 0.00% <ø> (ø)
internal/backends/mysql/metadata/registry.go 62.86% <ø> (-2.98%) ⬇️
... and 12 more

... and 21 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 67.12% <ø> (-2.57%) ⬇️
hana-1 ?
integration 67.12% <ø> (-2.63%) ⬇️
mongodb-1 5.25% <ø> (-0.04%) ⬇️
mysql-1 ?
mysql-2 ?
mysql-3 ?
postgresql-1 42.80% <ø> (-10.77%) ⬇️
postgresql-2 42.69% <ø> (-9.61%) ⬇️
postgresql-3 42.55% <ø> (-11.86%) ⬇️
postgresql-4 24.28% <ø> (-19.96%) ⬇️
postgresql-5 45.54% <ø> (-0.03%) ⬇️
sqlite-1 41.72% <ø> (-10.70%) ⬇️
sqlite-2 41.76% <ø> (-9.44%) ⬇️
sqlite-3 41.52% <ø> (-11.67%) ⬇️
sqlite-4 42.99% <ø> (-0.06%) ⬇️
sqlite-5 44.55% <ø> (-0.05%) ⬇️
unit 33.50% <ø> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi disabled auto-merge July 18, 2024 13:53
@AlekSi AlekSi merged commit 035827a into FerretDB:main Jul 18, 2024
41 of 64 checks passed
@AlekSi AlekSi deleted the remove-funccall branch July 18, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow is a code owner automatically assigned from FerretDB/leads

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.23.0
Development

Successfully merging this pull request may close these issues.
1 participant
@AlekSi