Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use slog in debug package #4473

Merged
merged 13 commits into from
Jul 22, 2024
Merged

Use slog in debug package #4473

merged 13 commits into from
Jul 22, 2024

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Jul 18, 2024 •
edited by AlekSi
Loading

Description

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/chore Code maintenance improvements label Jul 18, 2024
@chilagrow chilagrow added this to the Next milestone Jul 18, 2024
@chilagrow chilagrow self-assigned this Jul 18, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.20%. Comparing base (1a28bb6) to head (c0a5814).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4473      +/-   ##
==========================================
- Coverage   74.58%   71.20%   -3.38%     
==========================================
  Files         327      327              
  Lines       22774    22776       +2     
==========================================
- Hits        16986    16218     -768     
- Misses       4565     5328     +763     
- Partials     1223     1230       +7
Files Coverage Δ
integration/setup/startup.go 63.88% <100.00%> (ø)
internal/util/debug/debug.go 82.14% <71.42%> (+0.32%) ⬆️

... and 57 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 64.34% <40.00%> (-5.34%) ⬇️
hana-1 ?
integration 64.34% <40.00%> (-5.43%) ⬇️
mongodb-1 5.56% <40.00%> (+<0.01%) ⬆️
mysql-1 ?
mysql-2 ?
mysql-3 ?
postgresql-1 42.93% <40.00%> (-10.76%) ⬇️
postgresql-2 ?
postgresql-3 42.67% <40.00%> (-11.89%) ⬇️
postgresql-4 44.23% <40.00%> (-0.08%) ⬇️
postgresql-5 45.64% <40.00%> (-0.04%) ⬇️
sqlite-1 41.84% <40.00%> (-10.66%) ⬇️
sqlite-2 ?
sqlite-3 41.64% <40.00%> (-11.61%) ⬇️
sqlite-4 ?
sqlite-5 44.63% <40.00%> (-0.05%) ⬇️
unit 33.55% <71.42%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow marked this pull request as ready for review July 18, 2024 06:09
@chilagrow chilagrow requested a review from a team as a code owner July 18, 2024 06:09
@chilagrow chilagrow requested review from AlekSi, rumyantseva, a team and noisersup July 18, 2024 06:09
@chilagrow chilagrow enabled auto-merge (squash) July 18, 2024 06:09
@chilagrow chilagrow merged commit ddd5169 into FerretDB:main Jul 22, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@chilagrow @AlekSi @noisersup