Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use slog in oplog and cursor packages #4471

Merged
merged 7 commits into from
Jul 19, 2024
Merged

Use slog in oplog and cursor packages #4471

merged 7 commits into from
Jul 19, 2024

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Jul 17, 2024 •
edited by AlekSi
Loading

Description

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/chore Code maintenance improvements label Jul 17, 2024
@chilagrow chilagrow added this to the Next milestone Jul 17, 2024
@chilagrow chilagrow self-assigned this Jul 17, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 65.51724% with 10 lines in your changes missing coverage. Please review.

Project coverage is 73.74%. Comparing base (a2c4a0f) to head (cfebcf6).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4471      +/-   ##
==========================================
+ Coverage   73.71%   73.74%   +0.03%     
==========================================
  Files         327      327              
  Lines       22690    22694       +4     
==========================================
+ Hits        16725    16735      +10     
+ Misses       4734     4731       -3     
+ Partials     1231     1228       -3
Files Coverage Δ
internal/backends/decorators/oplog/backend.go 71.42% <100.00%> (ø)
internal/backends/decorators/oplog/database.go 100.00% <100.00%> (ø)
internal/clientconn/cursor/cursor.go 96.15% <100.00%> (ø)
internal/clientconn/cursor/registry.go 91.91% <100.00%> (+0.34%) ⬆️
internal/handler/handler.go 53.15% <100.00%> (ø)
internal/clientconn/conn.go 49.18% <0.00%> (ø)
internal/backends/decorators/oplog/collection.go 76.63% <20.00%> (ø)

... and 2 files with indirect coverage changes

Flag Coverage Δ
filter-true 67.21% <65.51%> (+0.03%) ⬆️
hana-1 ?
integration 67.21% <65.51%> (+0.03%) ⬆️
mongodb-1 5.25% <0.00%> (-0.01%) ⬇️
postgresql-1 42.82% <65.51%> (+0.01%) ⬆️
postgresql-2 42.74% <65.51%> (+0.01%) ⬆️
postgresql-3 42.57% <65.51%> (+0.03%) ⬆️
postgresql-4 44.24% <65.51%> (+0.12%) ⬆️
postgresql-5 45.57% <65.51%> (+<0.01%) ⬆️
sqlite-1 41.73% <65.51%> (+<0.01%) ⬆️
sqlite-2 41.79% <65.51%> (+<0.01%) ⬆️
sqlite-3 41.51% <65.51%> (+0.01%) ⬆️
sqlite-4 43.07% <65.51%> (+0.09%) ⬆️
sqlite-5 44.56% <65.51%> (+0.01%) ⬆️
unit 33.52% <65.51%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow changed the title Use slog in oplog Use slog in oplog and cursor packages Jul 17, 2024
@chilagrow chilagrow marked this pull request as ready for review July 17, 2024 09:28
@chilagrow chilagrow requested review from AlekSi and a team as code owners July 17, 2024 09:28
@chilagrow chilagrow requested review from rumyantseva, a team and noisersup July 17, 2024 09:28
@chilagrow chilagrow enabled auto-merge (squash) July 17, 2024 09:28
@chilagrow chilagrow mentioned this pull request Jul 18, 2024
Merged
9 tasks
@chilagrow chilagrow requested a review from AlekSi July 18, 2024 02:55
@chilagrow chilagrow merged commit b971577 into FerretDB:main Jul 19, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@chilagrow @AlekSi @noisersup