Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use slog in fsql #4464

Merged
merged 7 commits into from
Jul 23, 2024
Merged

Use slog in fsql #4464

merged 7 commits into from
Jul 23, 2024

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Jul 17, 2024 •
edited by AlekSi
Loading

Description

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/chore Code maintenance improvements label Jul 17, 2024
@chilagrow chilagrow added this to the Next milestone Jul 17, 2024
@chilagrow chilagrow self-assigned this Jul 17, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 73.52941% with 9 lines in your changes missing coverage. Please review.

Project coverage is 73.71%. Comparing base (ca5345b) to head (79e71e0).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4464      +/-   ##
==========================================
+ Coverage   73.69%   73.71%   +0.02%     
==========================================
  Files         330      330              
  Lines       22813    22811       -2     
==========================================
+ Hits        16811    16816       +5     
+ Misses       4764     4760       -4     
+ Partials     1238     1235       -3
Files Coverage Δ
internal/backends/mysql/metadata/pool/opendb.go 50.00% <100.00%> (ø)
internal/backends/sqlite/metadata/pool/opendb.go 60.86% <100.00%> (ø)
internal/util/fsql/db.go 80.64% <100.00%> (-0.31%) ⬇️
internal/backends/hana/backend.go 0.00% <0.00%> (ø)
internal/util/fsql/tx.go 57.14% <46.66%> (-1.00%) ⬇️

... and 3 files with indirect coverage changes

Flag Coverage Δ
filter-true 66.94% <70.58%> (+0.02%) ⬆️
hana-1 ?
integration 66.94% <70.58%> (+0.02%) ⬆️
mongodb-1 5.40% <0.00%> (+<0.01%) ⬆️
postgresql-1 42.67% <0.00%> (-0.01%) ⬇️
postgresql-2 42.60% <0.00%> (-0.01%) ⬇️
postgresql-3 42.38% <0.00%> (-0.03%) ⬇️
postgresql-4 44.07% <0.00%> (-0.03%) ⬇️
postgresql-5 45.42% <0.00%> (+0.02%) ⬆️
sqlite-1 41.58% <70.58%> (+<0.01%) ⬆️
sqlite-2 41.66% <70.58%> (+0.03%) ⬆️
sqlite-3 41.35% <70.58%> (+0.01%) ⬆️
sqlite-4 42.94% <70.58%> (+0.08%) ⬆️
sqlite-5 44.41% <70.58%> (+0.01%) ⬆️
unit 33.46% <73.52%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow marked this pull request as ready for review July 17, 2024 05:51
@chilagrow chilagrow requested review from AlekSi and a team as code owners July 17, 2024 05:51
@chilagrow chilagrow requested review from rumyantseva, a team and noisersup July 17, 2024 05:51
@chilagrow chilagrow enabled auto-merge (squash) July 17, 2024 05:52
AlekSi
AlekSi reviewed Jul 17, 2024
View reviewed changes
internal/util/fsql/tx.go Outdated Show resolved Hide resolved
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 18, 2024

@chilagrow this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Jul 18, 2024
@mergify mergify bot removed the conflict PRs that have merge conflicts label Jul 18, 2024
@chilagrow chilagrow requested a review from AlekSi July 18, 2024 02:07
AlekSi
AlekSi reviewed Jul 18, 2024
View reviewed changes
internal/util/fsql/tx.go Outdated Show resolved Hide resolved
@chilagrow chilagrow requested a review from AlekSi July 18, 2024 09:17
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 18, 2024

@chilagrow this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Jul 18, 2024
@mergify mergify bot removed the conflict PRs that have merge conflicts label Jul 19, 2024
rumyantseva
rumyantseva approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I like your attention to details!

@chilagrow chilagrow merged commit 3f1e013 into FerretDB:main Jul 23, 2024
32 checks passed
@AlekSi AlekSi changed the title Use slog in fsql Use slog in fsql Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi AlekSi approved these changes

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@chilagrow @AlekSi @rumyantseva @noisersup