Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use slog in mysql and hana backends #4463

Merged
merged 13 commits into from
Jul 19, 2024
Merged

Use slog in mysql and hana backends #4463

merged 13 commits into from
Jul 19, 2024

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Jul 17, 2024 •
edited by AlekSi
Loading

Description

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/chore Code maintenance improvements label Jul 17, 2024
@chilagrow chilagrow added this to the Next milestone Jul 17, 2024
@chilagrow chilagrow self-assigned this Jul 17, 2024
@chilagrow chilagrow changed the title use slog in backends Use slog in backends Jul 17, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.

Project coverage is 73.79%. Comparing base (035827a) to head (747ed3a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4463      +/-   ##
==========================================
+ Coverage   73.73%   73.79%   +0.05%     
==========================================
  Files         327      327              
  Lines       22690    22690              
==========================================
+ Hits        16731    16744      +13     
+ Misses       4730     4722       -8     
+ Partials     1229     1224       -5
Files Coverage Δ
internal/backends/mysql/backend.go 0.00% <ø> (ø)
internal/backends/mysql/metadata/registry.go 62.86% <100.00%> (ø)
internal/backends/hana/backend.go 0.00% <0.00%> (ø)
internal/handler/registry/hana.go 3.12% <0.00%> (ø)
internal/handler/registry/mysql.go 3.22% <0.00%> (ø)
internal/backends/mysql/metadata/pool/opendb.go 50.00% <50.00%> (ø)
internal/backends/mysql/metadata/pool/pool.go 48.48% <60.00%> (ø)

... and 8 files with indirect coverage changes

Flag Coverage Δ
filter-true 67.26% <0.00%> (+0.05%) ⬆️
hana-1 ?
integration 67.26% <0.00%> (+0.05%) ⬆️
mongodb-1 5.25% <0.00%> (ø)
postgresql-1 42.80% <0.00%> (ø)
postgresql-2 42.72% <0.00%> (-0.02%) ⬇️
postgresql-3 42.56% <0.00%> (+0.01%) ⬆️
postgresql-4 44.12% <0.00%> (-0.03%) ⬇️
postgresql-5 45.56% <0.00%> (+0.02%) ⬆️
sqlite-1 41.73% <0.00%> (ø)
sqlite-2 41.79% <0.00%> (+0.03%) ⬆️
sqlite-3 41.57% <0.00%> (+0.04%) ⬆️
sqlite-4 42.99% <0.00%> (+<0.01%) ⬆️
sqlite-5 44.52% <0.00%> (+<0.01%) ⬆️
unit 33.50% <46.15%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow changed the title Use slog in backends Use slog in mysql and hana backends Jul 17, 2024
@chilagrow chilagrow marked this pull request as ready for review July 17, 2024 06:55
@chilagrow chilagrow requested review from AlekSi and a team as code owners July 17, 2024 06:55
@chilagrow chilagrow requested a review from rumyantseva July 17, 2024 06:55
@chilagrow chilagrow enabled auto-merge (squash) July 17, 2024 06:55
@chilagrow chilagrow requested review from a team and noisersup July 17, 2024 06:55
AlekSi
AlekSi previously approved these changes Jul 17, 2024
View reviewed changes
noisersup
noisersup previously approved these changes Jul 18, 2024
View reviewed changes
@chilagrow chilagrow dismissed stale reviews from noisersup and AlekSi via 4e4418b July 18, 2024 02:17
@chilagrow chilagrow requested a review from AlekSi July 18, 2024 02:17
@chilagrow chilagrow requested a review from noisersup July 18, 2024 02:17
noisersup
noisersup approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chilagrow chilagrow added not ready Issues that are not ready to be worked on; PRs that should skip CI and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Jul 19, 2024
@chilagrow chilagrow merged commit a2c4a0f into FerretDB:main Jul 19, 2024
60 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@chilagrow @AlekSi @noisersup