Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use slog in main.go and embedded ferretdb package #4462

Merged
merged 18 commits into from
Jul 23, 2024
Merged

Use slog in main.go and embedded ferretdb package #4462

merged 18 commits into from
Jul 23, 2024

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Jul 17, 2024 •
edited by AlekSi
Loading

Description

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/chore Code maintenance improvements label Jul 17, 2024
@chilagrow chilagrow added this to the Next milestone Jul 17, 2024
@chilagrow chilagrow self-assigned this Jul 17, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.70%. Comparing base (6312dab) to head (5a56215).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4462   +/-   ##
=======================================
  Coverage   73.69%   73.70%           
=======================================
  Files         330      330           
  Lines       22859    22813   -46     
=======================================
- Hits        16846    16814   -32     
+ Misses       4772     4762   -10     
+ Partials     1241     1237    -4
Files Coverage Δ
integration/setup/startup.go 66.66% <100.00%> (ø)
internal/util/logging/buffer.go 83.33% <100.00%> (+22.22%) ⬆️
internal/util/logging/handler.go 78.57% <100.00%> (+1.35%) ⬆️
internal/util/logging/logging.go 61.90% <100.00%> (+8.96%) ⬆️
internal/util/logging/zap.go 0.00% <ø> (-84.00%) ⬇️
ferretdb/ferretdb.go 83.13% <71.42%> (-1.66%) ⬇️

... and 1 file with indirect coverage changes

Flag Coverage Δ
filter-true 66.93% <58.82%> (+0.18%) ⬆️
hana-1 ?
integration 66.93% <58.82%> (+0.18%) ⬆️
mongodb-1 5.39% <41.17%> (+0.03%) ⬆️
postgresql-1 42.66% <41.17%> (+0.09%) ⬆️
postgresql-2 42.57% <58.82%> (+0.11%) ⬆️
postgresql-3 42.39% <41.17%> (+0.07%) ⬆️
postgresql-4 44.08% <41.17%> (+0.09%) ⬆️
postgresql-5 45.42% <41.17%> (+0.11%) ⬆️
sqlite-1 41.57% <41.17%> (+0.09%) ⬆️
sqlite-2 41.65% <58.82%> (+0.14%) ⬆️
sqlite-3 41.36% <41.17%> (+0.08%) ⬆️
sqlite-4 42.85% <41.17%> (-0.01%) ⬇️
sqlite-5 44.39% <41.17%> (+0.10%) ⬆️
unit 33.46% <91.30%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 17, 2024

@chilagrow this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Jul 17, 2024
@mergify mergify bot removed the conflict PRs that have merge conflicts label Jul 18, 2024
@chilagrow chilagrow marked this pull request as ready for review July 18, 2024 07:43
@chilagrow chilagrow requested a review from a team as a code owner July 18, 2024 07:43
@chilagrow chilagrow requested review from AlekSi, rumyantseva, a team and noisersup July 18, 2024 07:43
@chilagrow chilagrow changed the title Use slog in main and embedded ferretdb package Use slog in main.go and embedded ferretdb package Jul 18, 2024
@chilagrow chilagrow enabled auto-merge (squash) July 18, 2024 07:44
AlekSi
AlekSi reviewed Jul 18, 2024
View reviewed changes
cmd/ferretdb/main.go Show resolved Hide resolved
ferretdb/ferretdb.go Outdated Show resolved Hide resolved
ferretdb/ferretdb.go Outdated Show resolved Hide resolved
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 19, 2024

@chilagrow this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Jul 19, 2024
@mergify mergify bot removed the conflict PRs that have merge conflicts label Jul 19, 2024
@chilagrow chilagrow requested a review from AlekSi July 19, 2024 05:59
noisersup
noisersup previously approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 22, 2024

@chilagrow this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Jul 22, 2024
@mergify mergify bot removed the conflict PRs that have merge conflicts label Jul 22, 2024
rumyantseva
rumyantseva previously approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 22, 2024

@chilagrow this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Jul 22, 2024
@mergify mergify bot removed the conflict PRs that have merge conflicts label Jul 23, 2024
rumyantseva
rumyantseva approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@chilagrow chilagrow merged commit ca5345b into FerretDB:main Jul 23, 2024
41 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi AlekSi approved these changes

@noisersup noisersup Awaiting requested review from noisersup

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@chilagrow @AlekSi @rumyantseva @noisersup