Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use slog in clientconn package #4457

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Use slog in clientconn package #4457

merged 2 commits into from
Jul 17, 2024

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Jul 16, 2024 •
edited by AlekSi
Loading

Description

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/chore Code maintenance improvements label Jul 16, 2024
@chilagrow chilagrow self-assigned this Jul 16, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 56.25000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 73.69%. Comparing base (42e52c4) to head (534cb8b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4457      +/-   ##
==========================================
- Coverage   74.45%   73.69%   -0.76%     
==========================================
  Files         328      328              
  Lines       22810    22818       +8     
==========================================
- Hits        16983    16816     -167     
- Misses       4612     4779     +167     
- Partials     1215     1223       +8
Files Coverage Δ
ferretdb/ferretdb.go 84.61% <100.00%> (+0.17%) ⬆️
integration/setup/listener.go 73.71% <100.00%> (-5.13%) ⬇️
internal/clientconn/listener.go 77.85% <85.71%> (ø)
internal/clientconn/conn.go 49.83% <38.70%> (-0.50%) ⬇️

... and 22 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 67.09% <45.65%> (-2.09%) ⬇️
hana-1 ?
integration 67.09% <45.65%> (-2.17%) ⬇️
mongodb-1 5.28% <0.00%> (-0.01%) ⬇️
mysql-1 ?
mysql-2 ?
mysql-3 ?
postgresql-1 42.65% <45.65%> (-10.39%) ⬇️
postgresql-2 42.56% <43.47%> (-9.26%) ⬇️
postgresql-3 42.38% <43.47%> (-11.50%) ⬇️
postgresql-4 43.96% <43.47%> (+0.31%) ⬆️
postgresql-5 45.32% <43.47%> (+0.29%) ⬆️
sqlite-1 41.81% <45.65%> (-10.32%) ⬇️
sqlite-2 41.88% <43.47%> (-9.03%) ⬇️
sqlite-3 41.65% <43.47%> (-11.20%) ⬇️
sqlite-4 43.09% <43.47%> (+0.30%) ⬆️
sqlite-5 44.61% <43.47%> (+0.30%) ⬆️
unit 33.58% <48.93%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow marked this pull request as ready for review July 17, 2024 03:00
@chilagrow chilagrow requested a review from a team as a code owner July 17, 2024 03:00
@chilagrow chilagrow requested review from AlekSi and rumyantseva July 17, 2024 03:00
@chilagrow chilagrow added this to the Next milestone Jul 17, 2024
@chilagrow chilagrow requested review from a team and noisersup July 17, 2024 03:01
@chilagrow chilagrow enabled auto-merge (squash) July 17, 2024 03:01
@chilagrow chilagrow merged commit d7cd1b4 into FerretDB:main Jul 17, 2024
33 of 35 checks passed
AlekSi
AlekSi reviewed Jul 17, 2024
View reviewed changes
internal/clientconn/conn.go
"Handler error for unhandled response opcode",
zap.Error(err), zap.Stringer("opcode", resHeader.OpCode),
logging.Error(err),
slog.Any("opcode", resHeader.OpCode),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be

slog.String("opcode", resHeader.OpCode.String())

Please fix another place too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this and other places addressed in #4471

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@chilagrow @AlekSi @noisersup