Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port pgx logger #4450

Merged
merged 7 commits into from
Jul 12, 2024
Merged

Port pgx logger #4450

merged 7 commits into from
Jul 12, 2024

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 11, 2024 •
edited
Loading

Description

Port a bridge between pgx and slog from v2.
It is not being used yet, that's for future PRs.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify mergify bot assigned AlekSi Jul 11, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 47 lines in your changes missing coverage. Please review.

Project coverage is 67.73%. Comparing base (12a7b60) to head (ccdb0c3).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4450      +/-   ##
==========================================
+ Coverage   63.96%   67.73%   +3.77%     
==========================================
  Files         319      328       +9     
  Lines       22233    22732     +499     
==========================================
+ Hits        14221    15398    +1177     
+ Misses       6853     6089     -764     
- Partials     1159     1245      +86
Files Coverage Δ
internal/util/logging/pgx.go 0.00% <0.00%> (ø)

... and 132 files with indirect coverage changes

Flag Coverage Δ
filter-true 60.05% <0.00%> (-3.91%) ⬇️
hana-1 ?
integration 60.05% <0.00%> (-3.91%) ⬇️
mongodb-1 5.29% <0.00%> (-0.02%) ⬇️
postgresql-1 42.30% <0.00%> (-0.09%) ⬇️
postgresql-3 42.06% <0.00%> (-0.06%) ⬇️
postgresql-4 43.60% <0.00%> (-0.17%) ⬇️
postgresql-5 ?
sqlite-1 41.46% <0.00%> (-0.09%) ⬇️
sqlite-3 41.27% <0.00%> (-0.07%) ⬇️
sqlite-4 42.78% <0.00%> (-0.10%) ⬇️
sqlite-5 ?
unit 33.64% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added this to the Next milestone Jul 11, 2024
@AlekSi AlekSi added the code/chore Code maintenance improvements label Jul 11, 2024
@AlekSi AlekSi marked this pull request as ready for review July 11, 2024 06:51
@AlekSi AlekSi requested a review from a team as a code owner July 11, 2024 06:51
@AlekSi AlekSi requested review from rumyantseva and chilagrow July 11, 2024 06:51
@AlekSi AlekSi enabled auto-merge (squash) July 11, 2024 06:51
@AlekSi AlekSi requested review from a team and noisersup July 11, 2024 06:51
rumyantseva
rumyantseva reviewed Jul 11, 2024
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, asked a couple of questions.

internal/util/logging/pgx.go Show resolved Hide resolved
internal/util/logging/pgx.go Show resolved Hide resolved
@AlekSi AlekSi requested a review from rumyantseva July 11, 2024 07:35
rumyantseva
rumyantseva previously approved these changes Jul 11, 2024
View reviewed changes
@AlekSi AlekSi requested review from chilagrow, rumyantseva and a team July 11, 2024 10:39
@AlekSi AlekSi merged commit 40e88a1 into FerretDB:main Jul 12, 2024
30 of 31 checks passed
@AlekSi AlekSi deleted the port-pgx-logger branch July 12, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@AlekSi @rumyantseva @chilagrow @noisersup