Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readiness probe cleanup #4447

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Readiness probe cleanup #4447

merged 1 commit into from
Jul 10, 2024

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Jul 10, 2024 •
edited
Loading

Description

Closes #4306.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@codecov Codecov
Copy link

codecov bot commented Jul 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.93%. Comparing base (204ec7f) to head (5e0a736).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4447      +/-   ##
==========================================
- Coverage   73.95%   73.93%   -0.03%     
==========================================
  Files         327      327              
  Lines       22674    22674              
==========================================
- Hits        16769    16763       -6     
- Misses       4672     4676       +4     
- Partials     1233     1235       +2

see 3 files with indirect coverage changes

Flag Coverage Δ
filter-true 66.79% <ø> (-0.03%) ⬇️
hana-1 ?
integration 66.79% <ø> (-0.03%) ⬇️
mongodb-1 5.30% <ø> (ø)
postgresql-1 42.39% <ø> (-0.01%) ⬇️
postgresql-2 42.30% <ø> (+0.02%) ⬆️
postgresql-3 42.12% <ø> (-0.01%) ⬇️
postgresql-4 43.77% <ø> (+0.08%) ⬆️
postgresql-5 45.08% <ø> (-0.01%) ⬇️
sqlite-1 41.55% <ø> (ø)
sqlite-2 41.58% <ø> (-0.05%) ⬇️
sqlite-3 41.34% <ø> (ø)
sqlite-4 42.87% <ø> (ø)
sqlite-5 44.33% <ø> (ø)
unit 33.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup added the code/chore Code maintenance improvements label Jul 10, 2024
@noisersup noisersup added this to the Next milestone Jul 10, 2024
@noisersup noisersup marked this pull request as ready for review July 10, 2024 11:04
@noisersup noisersup requested a review from a team as a code owner July 10, 2024 11:04
@noisersup noisersup requested review from AlekSi, rumyantseva, a team and chilagrow July 10, 2024 11:04
@noisersup noisersup enabled auto-merge (squash) July 10, 2024 11:04
@noisersup noisersup merged commit 8b4ec3d into FerretDB:main Jul 10, 2024
33 of 36 checks passed
@noisersup noisersup deleted the readiness-probe-refactor branch July 10, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi AlekSi approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow was automatically assigned from FerretDB/core

Assignees

@noisersup noisersup

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.23.0
Development

Successfully merging this pull request may close these issues.

Provide Kubernetes probes
3 participants
@noisersup @AlekSi @rumyantseva