Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore $readPreferences for insert #4440

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Ignore $readPreferences for insert #4440

merged 3 commits into from
Jul 10, 2024

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 9, 2024 •
edited
Loading

Description

The latest mongosh sends it:

rs0 [direct: primary] test> db.lala.insertOne({})
MongoServerError[FailedToParse]: insert: unknown field "$readPreference"

See also #3996.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Jul 9, 2024
@AlekSi AlekSi added this to the Next milestone Jul 9, 2024
@AlekSi AlekSi self-assigned this Jul 9, 2024
@AlekSi AlekSi marked this pull request as ready for review July 9, 2024 17:41
@AlekSi AlekSi requested a review from a team as a code owner July 9, 2024 17:41
@AlekSi AlekSi requested review from rumyantseva and chilagrow July 9, 2024 17:41
@AlekSi AlekSi enabled auto-merge (squash) July 9, 2024 17:41
@AlekSi AlekSi requested review from a team and noisersup July 9, 2024 17:41
@codecov Codecov
Copy link

codecov bot commented Jul 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.02%. Comparing base (b8d1f60) to head (e1985a4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4440      +/-   ##
==========================================
+ Coverage   73.96%   74.02%   +0.06%     
==========================================
  Files         327      327              
  Lines       22674    22674              
==========================================
+ Hits        16770    16785      +15     
+ Misses       4672     4663       -9     
+ Partials     1232     1226       -6
Files Coverage Δ
internal/handler/common/insert.go 100.00% <ø> (ø)

... and 6 files with indirect coverage changes

Flag Coverage Δ
filter-true 66.89% <ø> (+0.06%) ⬆️
hana-1 ?
integration 66.89% <ø> (+0.06%) ⬆️
mongodb-1 5.30% <ø> (ø)
postgresql-1 42.38% <ø> (-0.02%) ⬇️
postgresql-2 42.35% <ø> (+0.04%) ⬆️
postgresql-3 42.12% <ø> (ø)
postgresql-4 43.69% <ø> (-0.01%) ⬇️
postgresql-5 45.11% <ø> (+0.02%) ⬆️
sqlite-1 41.55% <ø> (+<0.01%) ⬆️
sqlite-2 41.60% <ø> (-0.01%) ⬇️
sqlite-3 41.35% <ø> (-0.02%) ⬇️
sqlite-4 42.84% <ø> (-0.03%) ⬇️
sqlite-5 44.35% <ø> (+0.01%) ⬆️
unit 33.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi mentioned this pull request Jul 9, 2024
Merged
9 tasks
@AlekSi AlekSi merged commit 9cf961e into FerretDB:main Jul 10, 2024
32 checks passed
@AlekSi AlekSi deleted the read-preferences branch July 10, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @chilagrow @noisersup