Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve support for named loggers #4432

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Improve support for named loggers #4432

merged 3 commits into from
Jul 9, 2024

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 8, 2024 •
edited
Loading

Description

Closes #4431.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi self-assigned this Jul 8, 2024
@AlekSi AlekSi added the code/enhancement Some user-visible feature could work better label Jul 8, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.

Project coverage is 73.97%. Comparing base (2aa742c) to head (f41e094).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4432      +/-   ##
==========================================
+ Coverage   73.89%   73.97%   +0.07%     
==========================================
  Files         327      327              
  Lines       22674    22674              
==========================================
+ Hits        16755    16773      +18     
+ Misses       4689     4670      -19     
- Partials     1230     1231       +1
Files Coverage Δ
internal/handler/msg_getlog.go 83.15% <100.00%> (ø)
internal/util/logging/buffer.go 88.88% <92.30%> (-5.85%) ⬇️
internal/util/logging/logging.go 29.41% <0.00%> (-3.93%) ⬇️

... and 8 files with indirect coverage changes

Flag Coverage Δ
filter-true 66.83% <86.20%> (+<0.01%) ⬆️
hana-1 ?
integration 66.83% <86.20%> (+<0.01%) ⬆️
mongodb-1 5.30% <24.13%> (ø)
postgresql-1 42.43% <24.13%> (+0.04%) ⬆️
postgresql-2 42.27% <86.20%> (-0.04%) ⬇️
postgresql-3 42.12% <24.13%> (+0.01%) ⬆️
postgresql-4 43.77% <24.13%> (-0.02%) ⬇️
postgresql-5 45.11% <24.13%> (+0.01%) ⬆️
sqlite-1 41.55% <24.13%> (ø)
sqlite-2 41.60% <86.20%> (-0.01%) ⬇️
sqlite-3 41.36% <24.13%> (+0.02%) ⬆️
sqlite-4 42.80% <24.13%> (-0.08%) ⬇️
sqlite-5 44.36% <24.13%> (+0.02%) ⬆️
unit 33.72% <58.62%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added this to the Next milestone Jul 8, 2024
@AlekSi AlekSi marked this pull request as ready for review July 8, 2024 19:28
@AlekSi AlekSi requested a review from a team as a code owner July 8, 2024 19:28
@AlekSi AlekSi requested review from rumyantseva and chilagrow July 8, 2024 19:28
@AlekSi AlekSi enabled auto-merge (squash) July 8, 2024 19:28
@AlekSi AlekSi requested review from a team and noisersup July 8, 2024 19:28
chilagrow
chilagrow previously approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this

internal/util/logging/buffer.go Outdated Show resolved Hide resolved
AlekSi and others added 2 commits July 9, 2024 07:31
@AlekSi AlekSi requested review from chilagrow and a team July 9, 2024 03:31
@AlekSi AlekSi disabled auto-merge July 9, 2024 03:43
@AlekSi AlekSi merged commit 24b7853 into FerretDB:main Jul 9, 2024
32 of 33 checks passed
@AlekSi AlekSi deleted the named-logger branch July 9, 2024 03:43
@AlekSi AlekSi changed the title Add stub for named slog logger helper Improve support for named loggers Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/enhancement Some user-visible feature could work better
Projects
Current Engineering
Archived in project
Milestone
v1.23.0
Development

Successfully merging this pull request may close these issues.

Add support for named slog loggers
2 participants
@AlekSi @chilagrow