Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable OTEL in tests where collection name might have non-UTF-8 symbols #4423

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Disable OTEL in tests where collection name might have non-UTF-8 symbols #4423

merged 2 commits into from
Jul 5, 2024

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented Jul 4, 2024 •
edited
Loading

Description

Closes #4345.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva self-assigned this Jul 4, 2024
@rumyantseva rumyantseva added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Jul 4, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.89%. Comparing base (507f7d6) to head (38b8f2a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4423      +/-   ##
==========================================
- Coverage   75.04%   73.89%   -1.16%     
==========================================
  Files         327      327              
  Lines       22643    22644       +1     
==========================================
- Hits        16993    16733     -260     
- Misses       4437     4679     +242     
- Partials     1213     1232      +19
Files Coverage Δ
integration/setup/client.go 71.05% <100.00%> (+0.78%) ⬆️
integration/setup/setup.go 78.74% <100.00%> (ø)
integration/setup/startup.go 65.33% <100.00%> (ø)
integration/setup/setup_compat.go 86.90% <66.66%> (-5.96%) ⬇️

... and 28 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 66.86% <90.90%> (-2.90%) ⬇️
hana-1 ?
integration 66.86% <90.90%> (-2.95%) ⬇️
mongodb-1 5.27% <63.63%> (+<0.01%) ⬆️
mysql-1 ?
mysql-2 ?
mysql-3 ?
postgresql-1 43.71% <81.81%> (-10.98%) ⬇️
postgresql-2 44.65% <81.81%> (-8.66%) ⬇️
postgresql-3 42.78% <81.81%> (-9.45%) ⬇️
postgresql-4 40.09% <81.81%> (-0.04%) ⬇️
postgresql-5 43.47% <81.81%> (-0.08%) ⬇️
sqlite-1 42.93% <81.81%> (-10.69%) ⬇️
sqlite-2 43.80% <81.81%> (-8.50%) ⬇️
sqlite-3 42.02% <81.81%> (-9.39%) ⬇️
sqlite-4 39.23% <81.81%> (-0.08%) ⬇️
sqlite-5 42.82% <81.81%> (-0.05%) ⬇️
unit 33.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@rumyantseva rumyantseva changed the title wip Disable OTEL in tests where collection name might have non UTF-8 symbols Jul 4, 2024
@rumyantseva rumyantseva added code/chore Code maintenance improvements and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Jul 4, 2024
@rumyantseva rumyantseva changed the title Disable OTEL in tests where collection name might have non UTF-8 symbols Disable OTEL in tests where collection name might have non-UTF-8 symbols Jul 4, 2024
@rumyantseva rumyantseva added this to the Next milestone Jul 4, 2024
@rumyantseva rumyantseva mentioned this pull request Jul 4, 2024
Closed
9 tasks
@rumyantseva rumyantseva marked this pull request as ready for review July 4, 2024 09:57
@rumyantseva rumyantseva requested a review from a team as a code owner July 4, 2024 09:57
@rumyantseva rumyantseva requested review from AlekSi and chilagrow July 4, 2024 09:57
@rumyantseva rumyantseva enabled auto-merge (squash) July 4, 2024 09:57
@rumyantseva rumyantseva requested review from a team and noisersup July 4, 2024 09:58
@rumyantseva rumyantseva merged commit 1a5e5fe into FerretDB:main Jul 5, 2024
32 of 38 checks passed
@rumyantseva rumyantseva deleted the customize-otel-monitor branch July 5, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@chilagrow chilagrow chilagrow approved these changes

@AlekSi AlekSi Awaiting requested review from AlekSi AlekSi is a code owner automatically assigned from FerretDB/leads

Assignees

@rumyantseva rumyantseva

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.23.0
Development

Successfully merging this pull request may close these issues.

Setup Otel exporter for FerretDB
3 participants
@rumyantseva @chilagrow @noisersup