Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract types and zap code into separate files #4408

Merged
merged 5 commits into from
Jul 3, 2024
Merged

Extract types and zap code into separate files #4408

merged 5 commits into from
Jul 3, 2024

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 2, 2024 •
edited
Loading

Description

This should make it easier to sync changes with v2.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Jul 2, 2024
@AlekSi AlekSi self-assigned this Jul 2, 2024
@AlekSi AlekSi changed the title Extract types code into separate file Extract types and zap code into separate files Jul 2, 2024
@AlekSi AlekSi added this to the Next milestone Jul 2, 2024
@AlekSi AlekSi removed the not ready Issues that are not ready to be worked on; PRs that should skip CI label Jul 2, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.58685% with 104 lines in your changes missing coverage. Please review.

Project coverage is 73.89%. Comparing base (7845441) to head (029ce46).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4408      +/-   ##
==========================================
+ Coverage   73.88%   73.89%   +0.01%     
==========================================
  Files         323      327       +4     
  Lines       22447    22638     +191     
==========================================
+ Hits        16584    16728     +144     
- Misses       4639     4681      +42     
- Partials     1224     1229       +5
Files Coverage Δ
internal/bson/array.go 43.75% <100.00%> (-10.31%) ⬇️
internal/bson/bson.go 92.30% <ø> (+9.23%) ⬆️
internal/bson/document.go 37.50% <100.00%> (-8.22%) ⬇️
internal/bson/raw_document.go 88.57% <100.00%> (+4.57%) ⬆️
internal/bson/raw_array.go 39.28% <25.00%> (-3.14%) ⬇️
internal/util/logging/console_handler.go 92.85% <92.85%> (ø)
internal/util/logging/zap.go 84.31% <84.31%> (ø)
internal/util/logging/logging.go 33.33% <33.33%> (-46.67%) ⬇️
internal/util/logging/handler.go 56.96% <56.96%> (ø)
internal/bson/types.go 75.72% <75.72%> (ø)

... and 6 files with indirect coverage changes

Flag Coverage Δ
filter-true 66.89% <45.07%> (-0.46%) ⬇️
hana-1 ?
integration 66.89% <45.07%> (-0.46%) ⬇️
mongodb-1 5.25% <16.19%> (+0.04%) ⬆️
postgresql-1 43.68% <45.07%> (-0.27%) ⬇️
postgresql-2 44.71% <45.07%> (-0.27%) ⬇️
postgresql-3 42.77% <45.07%> (-0.24%) ⬇️
postgresql-4 40.12% <45.07%> (-0.19%) ⬇️
postgresql-5 43.49% <45.07%> (-0.27%) ⬇️
sqlite-1 42.90% <45.07%> (-0.27%) ⬇️
sqlite-2 43.73% <45.07%> (-0.34%) ⬇️
sqlite-3 42.01% <45.07%> (-0.22%) ⬇️
sqlite-4 39.23% <45.07%> (-0.22%) ⬇️
sqlite-5 42.86% <45.07%> (-0.21%) ⬇️
unit 33.24% <75.58%> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Jul 2, 2024
@AlekSi AlekSi marked this pull request as ready for review July 2, 2024 15:47
@AlekSi AlekSi requested a review from a team as a code owner July 2, 2024 15:47
@AlekSi AlekSi requested review from rumyantseva and chilagrow July 2, 2024 15:47
@AlekSi AlekSi enabled auto-merge (squash) July 2, 2024 15:47
@AlekSi AlekSi requested review from a team and noisersup July 2, 2024 15:47
chilagrow
chilagrow approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this 🙏

@AlekSi AlekSi merged commit a28d03d into FerretDB:main Jul 3, 2024
50 of 54 checks passed
@AlekSi AlekSi deleted the bson-types branch July 3, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @chilagrow @noisersup