Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test authSource #4407

Merged
merged 12 commits into from
Jul 8, 2024
Merged

Test authSource #4407

merged 12 commits into from
Jul 8, 2024

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Jul 2, 2024 •
edited by rumyantseva
Loading

Description

Closes #4392.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/chore Code maintenance improvements label Jul 2, 2024
@chilagrow chilagrow added this to the v1.23.0 milestone Jul 2, 2024
@chilagrow chilagrow self-assigned this Jul 2, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.75%. Comparing base (be64b34) to head (82d2b53).

❗ There is a different number of reports uploaded between BASE (be64b34) and HEAD (82d2b53). Click for more details.

HEAD has 15 uploads less than BASE
Flag BASE (be64b34) HEAD (82d2b53)
integration 10 5
filter-true 10 5
hana-1 1 0
postgresql-2 1 0
sqlite-2 1 0
postgresql-3 1 0
sqlite-3 1 0
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4407      +/-   ##
==========================================
- Coverage   70.27%   63.75%   -6.52%     
==========================================
  Files         327      327              
  Lines       22652    22652              
==========================================
- Hits        15918    14442    -1476     
- Misses       5521     6934    +1413     
- Partials     1213     1276      +63

see 68 files with indirect coverage changes

Flag Coverage Δ
filter-true 55.53% <ø> (-7.31%) ⬇️
hana-1 ?
integration 55.53% <ø> (-7.31%) ⬇️
mongodb-1 5.22% <ø> (ø)
postgresql-1 42.19% <ø> (-1.44%) ⬇️
postgresql-2 ?
postgresql-3 ?
postgresql-4 43.61% <ø> (+3.58%) ⬆️
sqlite-1 41.35% <ø> (-1.50%) ⬇️
sqlite-2 ?
sqlite-3 ?
sqlite-4 42.79% <ø> (+3.62%) ⬆️
unit 33.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow marked this pull request as ready for review July 2, 2024 03:13
@chilagrow chilagrow requested a review from a team as a code owner July 2, 2024 03:13
@chilagrow chilagrow requested review from AlekSi, rumyantseva, a team and noisersup July 2, 2024 03:13
@chilagrow chilagrow enabled auto-merge (squash) July 2, 2024 03:14
rumyantseva
rumyantseva reviewed Jul 2, 2024
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, asked one question.

integration/users/connection_test.go Show resolved Hide resolved
AlekSi
AlekSi reviewed Jul 2, 2024
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In our dev setup, MongoDB authentication is disabled. Did we run those tests manually against MongoDB with auth enabled?

integration/users/connection_test.go Outdated Show resolved Hide resolved
@chilagrow chilagrow requested review from AlekSi and rumyantseva July 3, 2024 02:55
rumyantseva
rumyantseva approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chilagrow
Copy link
Member Author

In our dev setup, MongoDB authentication is disabled. Did we run those tests manually against MongoDB with auth enabled?

@AlekSi test-integration-mongodb uses port 47018 which is the docker image for MongoDB with authentication enabled right? No, I didn't run tests manually. What have I missed?

@AlekSi
Copy link
Member

AlekSi commented Jul 3, 2024

@chilagrow You are right, I confused mongodb.conf and mongodb_secured.conf

@chilagrow
Copy link
Member Author

Yeah, the dev environment setup is a bit too confusing and complicated...

@chilagrow chilagrow merged commit 5a93ea5 into FerretDB:main Jul 8, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi AlekSi approved these changes

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.23.0
Development

Successfully merging this pull request may close these issues.

Check database name during authentication
4 participants
@chilagrow @AlekSi @rumyantseva @noisersup